Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why apiHelper not using any separate dispatcher here? #1

Open
souravpalitrana opened this issue Nov 25, 2022 · 0 comments
Open

Why apiHelper not using any separate dispatcher here? #1

souravpalitrana opened this issue Nov 25, 2022 · 0 comments

Comments

@souravpalitrana
Copy link

souravpalitrana commented Nov 25, 2022

In SingleNetworkCall feature you are launching a coroutine in the viewmodel. As no dispatcher mentioned it uses the main thread. Again in the apiHelper suspend function there is no use of Dispathcer.IO . Should not we use that as it is doing I/O task? Yes retrofit it handling the network part. But still I am thinking of the right approach. @amitshekhariitbhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant