Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload fails when allegiance name has double quotes #28

Open
amoeba opened this issue May 6, 2020 · 1 comment
Open

Upload fails when allegiance name has double quotes #28

amoeba opened this issue May 6, 2020 · 1 comment
Assignees
Labels

Comments

@amoeba
Copy link
Owner

amoeba commented May 6, 2020

Tobin reported error 500s on upload and I see a JSON.parse failure. This is the culprit JSON:

'{
  "version": "2",
  "name": "Tobin",
  "race": "Sho",
  "gender": "Male",
  "level": 239,
  "allegiance_name": ""Guardians of the Lifestone"",

I didn't know allegiance names could have double quote chars in them so I didn't bother escaping. I really should escape them.

@amoeba amoeba added the bug label May 6, 2020
@amoeba amoeba self-assigned this May 6, 2020
@amoeba
Copy link
Owner Author

amoeba commented May 6, 2020

It's entirely possible retail didn't allow this so I might just close this and file a bug on whichever server code Drunkenfell uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant