fixup! .github: Allow individual steps to fail

Author: gastmaier

.github/workflows/build.yml

@@ -37,6 +37,7 @@ jobs:
   build:
     timeout-minutes: 7200
     runs-on: [self-hosted, v1]
+    # continue-on-error: true
 
     outputs:
       fail: ${{ steps.assert.outputs.fail }}
@@ -118,40 +119,32 @@ jobs:
         source ci/build.sh
         assert_compiled
 
-    - name: Halt execution
+    - name: Cancel steps
       if: ${{ failure() }}
       run: |
         echo "::error ::ci: Cannot proceed without a compiled kernel, the workflow will be cancelled."
-        until curl -L \
-          -X POST \
-          -H "Accept: application/vnd.github+json" \
-          -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-          -H "X-GitHub-Api-Version: 2022-11-28" \
-          "https://api.github.com/repos/${{ github.repository }}/actions/runs/${{ github.run_id }}/cancel" ; do
-          sleep 5
-        done
-        while true ; do sleep 10 ; done
+        "FATAL=true" >> "$GITHUB_ENV"
 
     - name: Sparse
-      if: ${{ !cancelled() && env.CHECKS_SPARCE == 'true' }}
+      if: ${{ !cancelled() && env.FATAL != 'true' && env.CHECKS_SPARCE == 'true' }}
       run: |
         source ci/build.sh
         compile_kernel_sparse
 
     - name: GCC fanalyzer
-      if: ${{ !cancelled() && env.CHECKS_GCC_FANALYZER == 'true' }}
+      if: ${{ !cancelled() && env.FATAL != 'true' && env.CHECKS_GCC_FANALYZER == 'true' }}
       run: |
         source ci/build.sh
         compile_gcc_fanalyzer
 
     - name: Clang analyzer
-      if: ${{ !cancelled() && env.CHECKS_CLANG_ANALYZER == 'true' }}
+      if: ${{ !cancelled() && env.FATAL != 'true' && env.CHECKS_CLANG_ANALYZER == 'true' }}
       run: |
         source ci/build.sh
         compile_clang_analyzer
 
     - name: Smatch
-      if: ${{ !cancelled() && env.CHECKS_SMATCH == 'true' }}
+      if: ${{ !cancelled() && env.FATAL != 'true' && env.CHECKS_SMATCH == 'true' }}
       run: |
         source ci/build.sh
         compile_kernel_smatch
@@ -169,3 +162,4 @@ jobs:
       run: |
         source ci/runner_env.sh
         export_labels
+        # [ "$FATAL" == 'true' ] && exit 1

.github/workflows/checks.yml

@@ -16,6 +16,7 @@ jobs:
   checks:
     timeout-minutes: 7200
     runs-on: [self-hosted, v1]
+    # continue-on-error: true
 
     outputs:
       fail: ${{ steps.assert.outputs.fail }}
@@ -29,28 +30,20 @@ jobs:
         source ci/build.sh
         apply_prerun
 
-    - name: Halt execution
+    - name: Cancel steps
       if: ${{ failure() }}
       run: >
         echo "::error ::ci: Cannot proceed at this condition, the workflow will be cancelled."
-        until curl -L \
-          -X POST \
-          -H "Accept: application/vnd.github+json" \
-          -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-          -H "X-GitHub-Api-Version: 2022-11-28" \
-          "https://api.github.com/repos/${{ github.repository }}/actions/runs/${{ github.run_id }}/cancel" ; do
-          sleep 5
-        done
-        while true ; do sleep 10 ; done
+        "FATAL=true" >> "$GITHUB_ENV"
 
     - name: License
-      if: ${{ !cancelled() }}
+      if: ${{ !cancelled() && env.FATAL != 'true' }}
       run: |
         source ci/build.sh
         check_license
 
     - name: Check patch
-      if: ${{ !cancelled() }}
+      if: ${{ !cancelled() && env.FATAL != 'true' }}
       run: |
         source ci/build.sh
         export -f check_checkpatch set_step_fail set_step_warn
@@ -59,7 +52,7 @@ jobs:
         exit $status
 
     - name: Coccicheck
-      if: ${{ !cancelled() }}
+      if: ${{ !cancelled() && env.FATAL != 'true' }}
       run: |
         source ci/build.sh
         export -f check_coccicheck set_step_fail set_step_warn
@@ -68,13 +61,13 @@ jobs:
         exit $status
 
     - name: CPP Check
-      if: ${{ !cancelled() }}
+      if: ${{ !cancelled() && env.FATAL != 'true' }}
       run: |
         source ci/build.sh
         check_cppcheck
 
     - name: Checkout and patch reference branch
-      if: ${{ !cancelled() && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
+      if: ${{ !cancelled() && env.FATAL != 'true' && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
       run: |
         git fetch origin --depth=1 "${{ inputs.ref_branch }}" &&
         git reset --hard origin/${{ inputs.ref_branch }} ||
@@ -110,13 +103,13 @@ jobs:
         done <<< "$files"
 
     - name: Check dt-bindings
-      if: ${{ !cancelled() }}
+      if: ${{ !cancelled() && env.FATAL != 'true' }}
       run: |
         source ci/build.sh
         check_dt_binding_check
 
     - name: Revert patch reference branch
-      if: ${{ !cancelled() && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
+      if: ${{ !cancelled() && env.FATAL != 'true' && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
       run: |
         git reset --hard $head_sha
 
@@ -126,4 +119,5 @@ jobs:
       run: |
         echo "warn=$(printenv | grep ^step_warn_ | grep -v =$ | tr '\n' ',' | sed 's/,$//')" >> "$GITHUB_OUTPUT"
         echo "fail=$(printenv | grep ^step_fail_ | grep -v =$ | tr '\n' ',' | sed 's/,$//')" >> "$GITHUB_OUTPUT"
+        # [ "$FATAL" == 'true' ] && exit 1