fixup! fixup! fixup! .github: Allow individual steps to fail

Author: gastmaier

.github/workflows/build.yml

@@ -119,32 +119,33 @@ jobs:
         source ci/build.sh
         assert_compiled
 
-    - name: Cancel steps
+    - name: Assert state
       if: ${{ failure() }}
       run: |
-        echo "::error ::ci: Cannot proceed without a compiled kernel, the workflow will be cancelled."
-        "FATAL=true" >> "$GITHUB_ENV"
+        source ci/build.sh
+        set_step_fail "assert_state"
+        "fatal=true" >> "$GITHUB_ENV"
 
     - name: Sparse
-      if: ${{ !cancelled() && env.FATAL != 'true' && env.CHECKS_SPARCE == 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' && env.CHECKS_SPARCE == 'true' }}
       run: |
         source ci/build.sh
         compile_kernel_sparse
 
     - name: GCC fanalyzer
-      if: ${{ !cancelled() && env.FATAL != 'true' && env.CHECKS_GCC_FANALYZER == 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' && env.CHECKS_GCC_FANALYZER == 'true' }}
       run: |
         source ci/build.sh
         compile_gcc_fanalyzer
 
     - name: Clang analyzer
-      if: ${{ !cancelled() && env.FATAL != 'true' && env.CHECKS_CLANG_ANALYZER == 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' && env.CHECKS_CLANG_ANALYZER == 'true' }}
       run: |
         source ci/build.sh
         compile_clang_analyzer
 
     - name: Smatch
-      if: ${{ !cancelled() && env.FATAL != 'true' && env.CHECKS_SMATCH == 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' && env.CHECKS_SMATCH == 'true' }}
       run: |
         source ci/build.sh
         compile_kernel_smatch
@@ -156,7 +157,7 @@ jobs:
         name: dist-${{ inputs.DEFCONFIG }}-${{ env.CID }}-${{ inputs.ARCH }}
         path: dist
 
-    - name: Assert
+    - name: Export labels
       if: ${{ !cancelled() }}
       id: assert
       run: |

.github/workflows/checks.yml

@@ -7,6 +7,8 @@ on:
         required: true
         type: string
     outputs:
+      fatal:
+        value: ${{ jobs.checks.outputs.fatal}}
       fail:
         value: ${{ jobs.checks.outputs.fail }}
       warn:
@@ -19,6 +21,7 @@ jobs:
     continue-on-error: true
 
     outputs:
+      fatal: ${{ steps.assert.outputs.fatal }}
       fail: ${{ steps.assert.outputs.fail }}
       warn: ${{ steps.assert.outputs.warn }}
 
@@ -30,20 +33,21 @@ jobs:
         source ci/build.sh
         apply_prerun
 
-    - name: Cancel steps
+    - name: Assert state
       if: ${{ failure() }}
-      run: >
-        echo "::error ::ci: Cannot proceed at this condition, the workflow will be cancelled."
-        "FATAL=true" >> "$GITHUB_ENV"
+      run: |
+        source ci/build.sh
+        set_step_fail "assert_state"
+        "fatal=true" >> "$GITHUB_ENV"
 
     - name: License
-      if: ${{ !cancelled() && env.FATAL != 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         check_license
 
     - name: Check patch
-      if: ${{ !cancelled() && env.FATAL != 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         export -f check_checkpatch set_step_fail set_step_warn
@@ -52,7 +56,7 @@ jobs:
         exit $status
 
     - name: Coccicheck
-      if: ${{ !cancelled() && env.FATAL != 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         export -f check_coccicheck set_step_fail set_step_warn
@@ -61,13 +65,13 @@ jobs:
         exit $status
 
     - name: CPP Check
-      if: ${{ !cancelled() && env.FATAL != 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         check_cppcheck
 
     - name: Checkout and patch reference branch
-      if: ${{ !cancelled() && env.FATAL != 'true' && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
+      if: ${{ !cancelled() && env.fatal != 'true' && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
       run: |
         git fetch origin --depth=1 "${{ inputs.ref_branch }}" &&
         git reset --hard origin/${{ inputs.ref_branch }} ||
@@ -103,20 +107,21 @@ jobs:
         done <<< "$files"
 
     - name: Check dt-bindings
-      if: ${{ !cancelled() && env.FATAL != 'true' }}
+      if: ${{ !cancelled() && env.fatal != 'true' }}
       run: |
         source ci/build.sh
         check_dt_binding_check
 
     - name: Revert patch reference branch
-      if: ${{ !cancelled() && env.FATAL != 'true' && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
+      if: ${{ !cancelled() && env.fatal != 'true' && !startsWith(github.base_ref, 'mirror/') && !startsWith(github.ref_name, 'mirror/') }}
       run: |
         git reset --hard $head_sha
 
-    - name: Assert checks
+    - name: Export labels
       if: ${{ !cancelled() }}
       id: assert
       run: |
-        echo "warn=$(printenv | grep ^step_warn_ | grep -v =$ | tr '\n' ',' | sed 's/,$//')" >> "$GITHUB_OUTPUT"
-        echo "fail=$(printenv | grep ^step_fail_ | grep -v =$ | tr '\n' ',' | sed 's/,$//')" >> "$GITHUB_OUTPUT"
+        echo "fatal=$fatal" >> "$GITHUB_OUTPUT"
+        source ci/runner_env.sh
+        export_labels
 

.github/workflows/top-level.yml

@@ -27,6 +27,7 @@ jobs:
   build_gcc_x86_64:
     uses: ./.github/workflows/build.yml
     needs: [checks]
+    if: needs.checks.outputs.fatal != 'true'
     secrets: inherit
     with:
       CXX: "14"
@@ -35,6 +36,7 @@ jobs:
   build_llvm_x86_64:
     uses: ./.github/workflows/build.yml
     needs: [checks]
+    if: needs.checks.outputs.fatal != 'true'
     secrets: inherit
     with:
       LLVM: "19"
@@ -44,6 +46,7 @@ jobs:
   build_gcc_aarch64:
     uses: ./.github/workflows/build.yml
     needs: [checks]
+    if: needs.checks.outputs.fatal != 'true'
     secrets: inherit
     with:
       CXX: "14"
@@ -52,7 +55,6 @@ jobs:
       DEFCONFIG: "adi_ci_defconfig"
   build_gcc_arm:
     uses: ./.github/workflows/build.yml
-    #needs: [checks]
     secrets: inherit
     with:
       CXX: "14"