fix: fix create local repository

Author: anancarv

.gitignore

@@ -127,3 +127,6 @@ dmypy.json
 
 # vscode
 .vscode/
+
+# ruff
+.ruff_cache

pyartifactory/objects/artifact.py

@@ -8,6 +8,7 @@
 
 import requests
 from pydantic import ValidationError
+from requests import Response
 
 from pyartifactory.exception import ArtifactNotFoundError, ArtifactoryError, BadPropertiesError, PropertyNotFoundError
 from pyartifactory.models.artifact import (
@@ -65,7 +66,8 @@ def info(self, artifact_path: Union[Path, str]) -> ArtifactInfoResponse:
                 artifact_info = ArtifactFileInfoResponse.model_validate(response.json())
             return artifact_info
         except requests.exceptions.HTTPError as error:
-            if error.response.status_code == 404:
+            http_response: Union[Response, None] = error.response
+            if isinstance(http_response, Response) and http_response.status_code == 404:
                 logger.error("Artifact %s does not exist", artifact_path)
                 raise ArtifactNotFoundError(f"Artifact {artifact_path} does not exist")
             raise ArtifactoryError from error
@@ -174,7 +176,8 @@ def list(
             artifact_list: ArtifactListResponse = ArtifactListResponse.model_validate(response.json())
             return artifact_list
         except requests.exceptions.HTTPError as error:
-            if error.response.status_code == 404:
+            http_response: Union[Response, None] = error.response
+            if isinstance(http_response, Response) and http_response.status_code == 404:
                 logger.error("Artifact %s does not exist", artifact_path)
                 raise ArtifactNotFoundError(f"Artifact {artifact_path} does not exist")
             raise ArtifactoryError from error
@@ -196,7 +199,8 @@ def properties(self, artifact_path: str, properties: Optional[List[str]] = None)
             logger.debug("Artifact Properties successfully retrieved")
             return ArtifactPropertiesResponse(**response.json())
         except requests.exceptions.HTTPError as error:
-            if error.response.status_code == 404:
+            http_response: Union[Response, None] = error.response
+            if isinstance(http_response, Response) and http_response.status_code == 404:
                 raise PropertyNotFoundError(f"Properties {properties} were not found on artifact {artifact_path}")
             raise ArtifactoryError from error
 
@@ -230,10 +234,11 @@ def set_properties(
             logger.debug("Artifact Properties successfully set")
             return self.properties(artifact_path)
         except requests.exceptions.HTTPError as error:
-            if error.response.status_code == 404:
+            http_response: Union[Response, None] = error.response
+            if isinstance(http_response, Response) and http_response.status_code == 404:
                 logger.error("Artifact %s does not exist", artifact_path)
                 raise ArtifactNotFoundError(f"Artifact {artifact_path} does not exist")
-            if error.response.status_code == 400:
+            if isinstance(http_response, Response) and http_response.status_code == 400:
                 logger.error("A property value includes forbidden special characters")
                 raise BadPropertiesError("A property value includes forbidden special characters")
             raise ArtifactoryError from error
@@ -263,7 +268,8 @@ def update_properties(
             logger.debug("Artifact Properties successfully updated")
             return self.properties(artifact_path)
         except requests.exceptions.HTTPError as error:
-            if error.response.status_code == 400:
+            http_response: Union[Response, None] = error.response
+            if isinstance(http_response, Response) and http_response.status_code == 400:
                 logger.error("Error updating artifact properties")
                 raise ArtifactoryError("Error updating artifact properties")
             raise ArtifactoryError from error

pyartifactory/objects/group.py

@@ -1,9 +1,10 @@
 from __future__ import annotations
 
 import logging
-from typing import List
+from typing import List, Union
 
 import requests
+from requests import Response
 
 from pyartifactory.exception import ArtifactoryError, GroupAlreadyExistsError, GroupNotFoundError
 from pyartifactory.models.group import Group
@@ -44,7 +45,8 @@ def get(self, name: str) -> Group:
             logger.debug("Group %s found", name)
             return Group(**response.json())
         except requests.exceptions.HTTPError as error:
-            if error.response.status_code in (404, 400):
+            http_response: Union[Response, None] = error.response
+            if isinstance(http_response, Response) and http_response.status_code in (404, 400):
                 logger.error("Group %s does not exist", name)
                 raise GroupNotFoundError(f"Group {name} does not exist")
             raise ArtifactoryError from error

pyartifactory/objects/repository.py

@@ -2,10 +2,11 @@
 
 import json
 import logging
-from typing import List, overload
+from typing import List, Union, overload
 
 import requests
 from pydantic import ValidationError
+from requests import Response
 
 from pyartifactory.exception import ArtifactoryError, RepositoryAlreadyExistsError, RepositoryNotFoundError
 from pyartifactory.models import AnyRepository, AnyRepositoryResponse
@@ -47,13 +48,14 @@ def get_repo(self, repo_name: str) -> AnyRepositoryResponse:
                     artifact_info = RemoteRepositoryResponse.model_validate(response.json())
             return artifact_info
         except requests.exceptions.HTTPError as error:
-            if error.response.status_code in (404, 400):
+            http_response: Union[Response, None] = error.response
+            if isinstance(http_response, Response) and http_response.status_code in (404, 400):
                 logger.error("Repository %s does not exist", repo_name)
                 raise RepositoryNotFoundError(f" Repository {repo_name} does not exist")
             raise ArtifactoryError from error
 
     @overload
-    def create_repo(self, repo: LocalRepositoryResponse) -> LocalRepositoryResponse:
+    def create_repo(self, repo: LocalRepository) -> LocalRepositoryResponse:
         ...
 
     @overload

pyartifactory/objects/user.py

@@ -1,9 +1,10 @@
 from __future__ import annotations
 
 import logging
-from typing import List
+from typing import List, Union
 
 import requests
+from requests import Response
 
 from pyartifactory.exception import ArtifactoryError, UserAlreadyExistsError, UserNotFoundError
 from pyartifactory.models.user import NewUser, SimpleUser, User, UserResponse
@@ -46,7 +47,8 @@ def get(self, name: str) -> UserResponse:
             logger.debug("User %s found", name)
             return UserResponse(**response.json())
         except requests.exceptions.HTTPError as error:
-            if error.response.status_code in (404, 400):
+            http_response: Union[Response, None] = error.response
+            if isinstance(http_response, Response) and http_response.status_code in (404, 400):
                 logger.error("User %s does not exist", name)
                 raise UserNotFoundError(f"{name} does not exist")
             raise ArtifactoryError from error