chore: functional converter with spdx 3

Signed-off-by: Keith Zantow <[email protected]>

Author: kzantow

convert_func.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 	"reflect"
+	"slices"
 )
 
 type FuncChain interface {
@@ -238,13 +239,16 @@ type reflectConvertStep struct {
 	convertFunc reflectConvertFunc
 }
 
-func (c funcChain) shortestChain(fromType reflect.Type, targetType reflect.Type) []reflectConvertStep {
+func (c funcChain) shortestChain(fromType reflect.Type, targetType reflect.Type, visited ...reflect.Type) []reflectConvertStep {
 	var shortest []reflectConvertStep
 	for toType, convertFunc := range c.funcs[fromType] {
+		if slices.Contains(visited, toType) {
+			continue
+		}
 		if toType == targetType {
 			return []reflectConvertStep{{toType, convertFunc}}
 		}
-		chain := c.shortestChain(toType, targetType)
+		chain := c.shortestChain(toType, targetType, append(visited, fromType)...)
 		if chain != nil {
 			chain = append([]reflectConvertStep{{toType, convertFunc}}, chain...)
 		}

converter.go

@@ -142,6 +142,10 @@ func (c *conversion) getValue(fromValue reflect.Value, targetType reflect.Type)
 		toValue = fromValue
 	}
 
+	if !toValue.IsValid() {
+		return nilValue
+	}
+
 	// handle non-pointer returns -- the reflect.New earlier always creates a pointer
 	if !isPtr(baseTargetType) {
 		toValue = fromPtr(toValue)
@@ -235,6 +239,9 @@ func (c *conversion) convertValueTypes(value reflect.Value, targetType reflect.T
 
 func (c *conversion) findConvertableType(fromType reflect.Type, targetType reflect.Type) reflect.Type {
 	converters := c.chain.funcs[fromType]
+	if converters == nil {
+		return nil
+	}
 	if v, ok := converters[targetType]; ok {
 		if v == nil {
 			return nil