cleaning and adding ecto as dep

Author: julien-leclercq

lib/ecto_atom.ex

@@ -17,14 +17,11 @@ defmodule Ecto.Atom do
   def type, do: :string
 
   def cast(value) when is_atom(value), do: {:ok, value}
-  # `to_string` not working, why ?
-  # def cast(value) when is_string(value), do: {:ok, String.to_atom(value)}
   def cast(_), do: :error
 
   def load(value), do: {:ok, String.to_atom(value)}
 
   def dump(value) when is_atom(value), do: {:ok, Atom.to_string(value)}
-  # `to_string` not working, why ?
-  # def dump(value) when is_string(value), do: {:ok, value}
   def dump(_), do: :error
+
 end

mix.exs

@@ -28,6 +28,6 @@ defmodule Ecto.Atom.Mixfile do
   #
   # Type "mix help deps" for more examples and options
   defp deps do
-    []
+    [{:ecto, "~> 2.1"}]
   end
 end

mix.lock

@@ -0,0 +1,3 @@
+%{"decimal": {:hex, :decimal, "1.4.0", "fac965ce71a46aab53d3a6ce45662806bdd708a4a95a65cde8a12eb0124a1333", [:mix], []},
+  "ecto": {:hex, :ecto, "2.1.4", "d1ba932813ec0e0d9db481ef2c17777f1cefb11fc90fa7c142ff354972dfba7e", [:mix], [{:db_connection, "~> 1.1", [hex: :db_connection, optional: true]}, {:decimal, "~> 1.2", [hex: :decimal, optional: false]}, {:mariaex, "~> 0.8.0", [hex: :mariaex, optional: true]}, {:poison, "~> 2.2 or ~> 3.0", [hex: :poison, optional: true]}, {:poolboy, "~> 1.5", [hex: :poolboy, optional: false]}, {:postgrex, "~> 0.13.0", [hex: :postgrex, optional: true]}, {:sbroker, "~> 1.0", [hex: :sbroker, optional: true]}]},
+  "poolboy": {:hex, :poolboy, "1.5.1", "6b46163901cfd0a1b43d692657ed9d7e599853b3b21b95ae5ae0a777cf9b6ca8", [:rebar], []}}

test/ecto_atom_test.exs

@@ -14,12 +14,6 @@ defmodule Ecto.AtomTest do
     assert Ecto.Atom.load("string") == {:ok, :string}
   end
 
-  # `to_string` not working, why ?
-  # Can't understand the below comment :/
-  test "dump string" do
-    assert Ecto.Atom.dump("string") == :error
-  end
-
   test "can load past dumped data" do
     { :ok, dumped_atom } = Ecto.Atom.dump :atom
     assert Ecto.Atom.load(dumped_atom) == { :ok, :atom }
@@ -28,4 +22,8 @@ defmodule Ecto.AtomTest do
   test "dump :atom" do
     assert Ecto.Atom.dump(:atom) == {:ok, "atom"}
   end
+
+  test "dump string" do
+    assert Ecto.Atom.dump("string") == :error
+  end
 end