Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify the package source #27

Open
danielmarbach opened this issue Apr 10, 2015 · 7 comments
Open

Ability to specify the package source #27

danielmarbach opened this issue Apr 10, 2015 · 7 comments
Milestone

Comments

@danielmarbach
Copy link
Contributor

Discussed with @adamralph it would be cool to be able to specify the package source. I think we could restrict ourself to only public sources like Nuget and MyGet.

How would the URI schema look like? @SeanFeldman and I agree that we need to go back to the drawing board to also solve #23

@adamralph
Copy link

This would be awesome. The use case is comparing the current release to the current pre-release in myget.

I like the way the comparisons are addressable, but I guess it could get quite messy if you had to have an encoded URL in the URL 😝

I guess one way is to have defined aliases,

e.g. 'nuget' => nuget gallery feed URL, 'myget/myfeed' = myget root URL/myfeed

but it would be nicer, of course, to work against any package source.

@danielmarbach
Copy link
Contributor Author

@adamralph as soon as we need package feed authentication it gets complicated pretty quickly. I think we need to start small

@SeanFeldman
Copy link
Contributor

+1 for this info @adamralph
Any package requirement can get tricky - private feeds would require authentication.
What we need (discussed with @danielmarbach) is to define what APIComparer will or will not provide.

@adamralph
Copy link

Yeah, agreed. No point trying to solve the world straight away. A specific scheme to just support myget would be good initial enhancement.

@andreasohlund
Copy link
Owner

Side note: this already works for the CLI which is very handy when you want to check your pull/feature branch for diffs against latest build:

https://github.com/ParticularLabs/APIComparer/blob/master/APIComparer/Program.cs#L18

@danielmarbach
Copy link
Contributor Author

Yeah but the API is the new console and the API doesn’t support it

@andreasohlund
Copy link
Owner

I said it was a side note :)

@andreasohlund andreasohlund added this to the vNext milestone Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants