Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing between .NET framework targets #28

Closed
danielmarbach opened this issue Apr 15, 2015 · 6 comments · Fixed by #35
Closed

Comparing between .NET framework targets #28

danielmarbach opened this issue Apr 15, 2015 · 6 comments · Fixed by #35
Assignees
Labels
Milestone

Comments

@danielmarbach
Copy link
Contributor

We discussed this today #23. We came to the following conclusion:

We compare nuget packages. So removing a target framework or changing a target framework can be considered as a breaking change in certain scenarios. We will be using the following algorithm

  1. Download the nuget package
  2. For every target on the leftVersion side we will compare against the matching target on the rightVersion side
  3. In case when the rightVersion side does no longer have a target from the leftVersion side we consider this as a breaking change
  4. In case when the rightVersion side has a target which is not existent on the leftVersion side we compare this target against the highest target on the leftVersion side

Examples

PackageFoo V1-------------PackageFoo V2
NET35--------------------------NET451
NET40--------------------------NET45
------------------------------------NET40

Report

This is the comparison of PackageFoo V1 to PackageFoo V2. The comparison detected the following breaking and non-breaking changes.

NET451

The following types have differences.
The following types have Obsoletes.

NET45

The following types have differences.
The following types have Obsoletes.

NET40

The following types have differences.
The following types have Obsoletes.

NET35

Was removed. Breaking change.

@danielmarbach danielmarbach added this to the 1.0.0 milestone Apr 15, 2015
@danielmarbach
Copy link
Contributor Author

@ursenzler @philippdolder thoughts and additions from your side?

@philippdolder
Copy link

@danielmarbach looks good to me

@ursenzler
Copy link

Yes that would allow to compare versions with a .Net upgrade inbetween, e.g. leftVersion was built against 3.5 and rightVersion against 4.5. Which I consider a frequent case.

@andreasohlund
Copy link
Owner

I'll take a stab at this one

@andreasohlund
Copy link
Owner

@philippdolder http://apicomparer-preview.particular.net/Compare/Appccelerate.EventBroker/2.0.84...3.15.0 now shows the targets better, can you take a quick look?

Still need to figure out why the new type doesn't show as you mention in #34

@philippdolder
Copy link

@andreasohlund looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants