-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparing between .NET framework targets #28
Comments
@ursenzler @philippdolder thoughts and additions from your side? |
@danielmarbach looks good to me |
Yes that would allow to compare versions with a .Net upgrade inbetween, e.g. leftVersion was built against 3.5 and rightVersion against 4.5. Which I consider a frequent case. |
I'll take a stab at this one |
@philippdolder http://apicomparer-preview.particular.net/Compare/Appccelerate.EventBroker/2.0.84...3.15.0 now shows the targets better, can you take a quick look? Still need to figure out why the new type doesn't show as you mention in #34 |
@andreasohlund looks good |
We discussed this today #23. We came to the following conclusion:
We compare nuget packages. So removing a target framework or changing a target framework can be considered as a breaking change in certain scenarios. We will be using the following algorithm
leftVersion
side we will compare against the matching target on therightVersion
siderightVersion
side does no longer have a target from theleftVersion
side we consider this as a breaking changerightVersion
side has a target which is not existent on theleftVersion
side we compare this target against the highest target on theleftVersion
sideExamples
PackageFoo V1-------------PackageFoo V2
NET35--------------------------NET451
NET40--------------------------NET45
------------------------------------NET40
Report
This is the comparison of PackageFoo V1 to PackageFoo V2. The comparison detected the following breaking and non-breaking changes.
NET451
The following types have differences.
The following types have Obsoletes.
NET45
The following types have differences.
The following types have Obsoletes.
NET40
The following types have differences.
The following types have Obsoletes.
NET35
Was removed. Breaking change.
The text was updated successfully, but these errors were encountered: