Skip to content

Commit 2770558

Browse files
committed
Deprecate Util.SDK_INT in favor of Build.VERSION.SDK_INT
`Util.SDK_INT` was introduced to be able to simulate any SDK version during tests. This is possible by using Robolectric's `@Config(sdk)` annotation. All usages of `Util.SDK_INT` have been replaced by `Build.VERSION.SDK_INT`. This is a similar change to what was done in #2107.
1 parent ed56ed2 commit 2770558

File tree

147 files changed

+623
-576
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

147 files changed

+623
-576
lines changed

demos/composition/src/main/java/androidx/media3/demo/composition/CompositionPreviewActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package androidx.media3.demo.composition;
1717

1818
import static android.content.pm.ActivityInfo.COLOR_MODE_HDR;
19-
import static androidx.media3.common.util.Util.SDK_INT;
19+
import static android.os.Build.VERSION.SDK_INT;
2020
import static androidx.media3.transformer.Composition.HDR_MODE_EXPERIMENTAL_FORCE_INTERPRET_HDR_AS_SDR;
2121
import static androidx.media3.transformer.Composition.HDR_MODE_KEEP_HDR;
2222
import static androidx.media3.transformer.Composition.HDR_MODE_TONE_MAP_HDR_TO_SDR_USING_MEDIACODEC;

demos/effect/src/main/java/androidx/media3/demo/effect/EffectActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package androidx.media3.demo.effect
1717

1818
import android.Manifest
1919
import android.net.Uri
20+
import android.os.Build.VERSION.SDK_INT
2021
import android.os.Bundle
2122
import android.text.Spannable
2223
import android.text.SpannableString
@@ -81,7 +82,6 @@ import androidx.lifecycle.lifecycleScope
8182
import androidx.media3.common.Effect
8283
import androidx.media3.common.MediaItem
8384
import androidx.media3.common.util.UnstableApi
84-
import androidx.media3.common.util.Util.SDK_INT
8585
import androidx.media3.effect.Contrast
8686
import androidx.media3.effect.OverlayEffect
8787
import androidx.media3.effect.StaticOverlaySettings

demos/gl/src/main/java/androidx/media3/demo/gl/MainActivity.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package androidx.media3.demo.gl;
1717

18+
import static android.os.Build.VERSION.SDK_INT;
1819
import static androidx.media3.common.util.Assertions.checkNotNull;
1920

2021
import android.app.Activity;
@@ -94,7 +95,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
9495
@Override
9596
public void onStart() {
9697
super.onStart();
97-
if (Util.SDK_INT > 23) {
98+
if (SDK_INT > 23) {
9899
initializePlayer();
99100
if (playerView != null) {
100101
playerView.onResume();
@@ -105,7 +106,7 @@ public void onStart() {
105106
@Override
106107
public void onResume() {
107108
super.onResume();
108-
if (Util.SDK_INT <= 23 || player == null) {
109+
if (SDK_INT <= 23 || player == null) {
109110
initializePlayer();
110111
if (playerView != null) {
111112
playerView.onResume();
@@ -116,7 +117,7 @@ public void onResume() {
116117
@Override
117118
public void onPause() {
118119
super.onPause();
119-
if (Util.SDK_INT <= 23) {
120+
if (SDK_INT <= 23) {
120121
if (playerView != null) {
121122
playerView.onPause();
122123
}
@@ -127,7 +128,7 @@ public void onPause() {
127128
@Override
128129
public void onStop() {
129130
super.onStop();
130-
if (Util.SDK_INT > 23) {
131+
if (SDK_INT > 23) {
131132
if (playerView != null) {
132133
playerView.onPause();
133134
}

demos/transformer/src/main/java/androidx/media3/demo/transformer/ConfigurationActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717

1818
import static android.Manifest.permission.READ_EXTERNAL_STORAGE;
1919
import static android.Manifest.permission.READ_MEDIA_VIDEO;
20+
import static android.os.Build.VERSION.SDK_INT;
2021
import static androidx.media3.common.util.Assertions.checkState;
21-
import static androidx.media3.common.util.Util.SDK_INT;
2222
import static androidx.media3.transformer.Composition.HDR_MODE_EXPERIMENTAL_FORCE_INTERPRET_HDR_AS_SDR;
2323
import static androidx.media3.transformer.Composition.HDR_MODE_KEEP_HDR;
2424
import static androidx.media3.transformer.Composition.HDR_MODE_TONE_MAP_HDR_TO_SDR_USING_MEDIACODEC;

demos/transformer/src/main/java/androidx/media3/demo/transformer/TransformerActivity.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
package androidx.media3.demo.transformer;
1717

1818
import static android.content.pm.ServiceInfo.FOREGROUND_SERVICE_TYPE_MEDIA_PROJECTION;
19+
import static android.os.Build.VERSION.SDK_INT;
1920
import static androidx.media3.common.util.Assertions.checkNotNull;
2021
import static androidx.media3.common.util.Assertions.checkState;
2122
import static androidx.media3.exoplayer.DefaultLoadControl.DEFAULT_BUFFER_FOR_PLAYBACK_AFTER_REBUFFER_MS;
@@ -985,14 +986,14 @@ public int onStartCommand(Intent intent, int flags, int startId) {
985986
.setOngoing(true)
986987
.setSmallIcon(R.drawable.exo_icon_play)
987988
.build();
988-
if (Util.SDK_INT >= 26) {
989+
if (SDK_INT >= 26) {
989990
NotificationChannel channel =
990991
new NotificationChannel(
991992
CHANNEL_ID, CHANNEL_NAME, NotificationManager.IMPORTANCE_HIGH);
992993
NotificationManager manager = getSystemService(NotificationManager.class);
993994
manager.createNotificationChannel(channel);
994995
}
995-
if (Util.SDK_INT >= 29) {
996+
if (SDK_INT >= 29) {
996997
startForeground(NOTIFICATION_ID, notification, FOREGROUND_SERVICE_TYPE_MEDIA_PROJECTION);
997998
} else {
998999
startForeground(NOTIFICATION_ID, notification);

libraries/cast/src/main/java/androidx/media3/cast/CastPlayer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
*/
1616
package androidx.media3.cast;
1717

18+
import static android.os.Build.VERSION.SDK_INT;
1819
import static androidx.media3.common.util.Assertions.checkArgument;
1920
import static androidx.media3.common.util.Assertions.checkNotNull;
20-
import static androidx.media3.common.util.Util.SDK_INT;
2121
import static androidx.media3.common.util.Util.castNonNull;
2222
import static java.lang.Math.min;
2323

libraries/common/src/main/java/androidx/media3/common/AudioAttributes.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
*/
1616
package androidx.media3.common;
1717

18+
import static android.os.Build.VERSION.SDK_INT;
19+
1820
import android.os.Bundle;
1921
import androidx.annotation.Nullable;
2022
import androidx.annotation.RequiresApi;
@@ -45,10 +47,10 @@ private AudioAttributesV21(AudioAttributes audioAttributes) {
4547
.setContentType(audioAttributes.contentType)
4648
.setFlags(audioAttributes.flags)
4749
.setUsage(audioAttributes.usage);
48-
if (Util.SDK_INT >= 29) {
50+
if (SDK_INT >= 29) {
4951
Api29.setAllowedCapturePolicy(builder, audioAttributes.allowedCapturePolicy);
5052
}
51-
if (Util.SDK_INT >= 32) {
53+
if (SDK_INT >= 32) {
5254
Api32.setSpatializationBehavior(builder, audioAttributes.spatializationBehavior);
5355
}
5456
this.audioAttributes = builder.build();

libraries/common/src/main/java/androidx/media3/common/BundleListRetriever.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package androidx.media3.common;
1717

18+
import static android.os.Build.VERSION.SDK_INT;
1819
import static androidx.media3.common.util.Assertions.checkNotNull;
1920

2021
import android.os.Binder;
@@ -25,7 +26,6 @@
2526
import androidx.annotation.Nullable;
2627
import androidx.annotation.VisibleForTesting;
2728
import androidx.media3.common.util.UnstableApi;
28-
import androidx.media3.common.util.Util;
2929
import com.google.common.collect.ImmutableList;
3030
import java.util.List;
3131

@@ -56,7 +56,7 @@ public final class BundleListRetriever extends Binder {
5656

5757
// Soft limit of an IPC buffer size
5858
private static final int SUGGESTED_MAX_IPC_SIZE =
59-
Util.SDK_INT >= 30 ? IBinder.getSuggestedMaxIpcSizeBytes() : 64 * 1024;
59+
SDK_INT >= 30 ? IBinder.getSuggestedMaxIpcSizeBytes() : 64 * 1024;
6060

6161
private static final int REPLY_END_OF_LIST = 0;
6262
private static final int REPLY_CONTINUE = 1;

libraries/common/src/main/java/androidx/media3/common/FlagSet.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515
*/
1616
package androidx.media3.common;
1717

18+
import static android.os.Build.VERSION.SDK_INT;
1819
import static androidx.media3.common.util.Assertions.checkIndex;
1920
import static androidx.media3.common.util.Assertions.checkState;
2021

2122
import android.util.SparseBooleanArray;
2223
import androidx.annotation.Nullable;
2324
import androidx.media3.common.util.UnstableApi;
24-
import androidx.media3.common.util.Util;
2525
import com.google.errorprone.annotations.CanIgnoreReturnValue;
2626

2727
/**
@@ -222,7 +222,7 @@ public boolean equals(@Nullable Object o) {
222222
return false;
223223
}
224224
FlagSet that = (FlagSet) o;
225-
if (Util.SDK_INT < 24) {
225+
if (SDK_INT < 24) {
226226
// SparseBooleanArray.equals() is not implemented on API levels below 24.
227227
if (size() != that.size()) {
228228
return false;
@@ -240,7 +240,7 @@ public boolean equals(@Nullable Object o) {
240240

241241
@Override
242242
public int hashCode() {
243-
if (Util.SDK_INT < 24) {
243+
if (SDK_INT < 24) {
244244
// SparseBooleanArray.hashCode() is not implemented on API levels below 24.
245245
int hashCode = size();
246246
for (int i = 0; i < size(); i++) {

libraries/common/src/main/java/androidx/media3/common/audio/AudioFocusRequestCompat.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package androidx.media3.common.audio;
1717

18+
import static android.os.Build.VERSION.SDK_INT;
1819
import static androidx.media3.common.util.Assertions.checkArgument;
1920
import static androidx.media3.common.util.Assertions.checkNotNull;
2021

@@ -55,15 +56,15 @@ public final class AudioFocusRequestCompat {
5556
this.audioAttributes = audioFocusRequestCompat;
5657
this.pauseOnDuck = pauseOnDuck;
5758

58-
if (Util.SDK_INT < 26) {
59+
if (SDK_INT < 26) {
5960
this.onAudioFocusChangeListener =
6061
new OnAudioFocusChangeListenerHandlerCompat(
6162
onAudioFocusChangeListener, focusChangeHandler);
6263
} else {
6364
this.onAudioFocusChangeListener = onAudioFocusChangeListener;
6465
}
6566

66-
if (Util.SDK_INT >= 26) {
67+
if (SDK_INT >= 26) {
6768
this.frameworkAudioFocusRequest =
6869
new AudioFocusRequest.Builder(focusGain)
6970
.setAudioAttributes(audioAttributes.getAudioAttributesV21().audioAttributes)

0 commit comments

Comments
 (0)