Skip to content

MenuEntry: Implement menu role functionality for platform integration #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MenuEntry: Implement menu role functionality for platform integration #1519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions angrmanagement/ui/menus/menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def __init__(
checked: bool = False,
enabled: bool = True,
key=None,
role: QAction.MenuRole = QAction.MenuRole.NoRole,
role: QAction.MenuRole | None = None,
icon: QIcon | None = None,
) -> None:
self.caption = caption
Expand All @@ -31,10 +31,10 @@ def __init__(
self.checked_initially = checked
self.enabled = enabled
self.key = key
self.role = role
self.icon = icon

self._qaction = None
self._role = role

def set_qaction(self, qaction: QAction) -> None:
self._qaction = qaction
Expand Down Expand Up @@ -130,6 +130,9 @@ def translate_element(menu, entry, index=None):
action.setCheckable(True)
action.setChecked(entry.checked_initially)

if entry.role is not None:
action.setMenuRole(entry.role)

if before is None:
menu.addAction(action)
else:
Expand Down
Loading