Skip to content

Commit c08b779

Browse files
danielmurrmanndanielmurrmann
committed
Fixed tests for zoneless
1 parent a446f1a commit c08b779

17 files changed

+55
-52
lines changed

‎libs/ngrx-hateoas/src/lib/pipes/get-action.pipe.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { TestBed } from '@angular/core/testing';
22
import { GetActionPipe } from './get-action.pipe';
33
import { HateoasService } from '../services/hateoas.service';
4+
import { provideZonelessChangeDetection } from '@angular/core';
45

56
const testModel = {
67
_actions: {
@@ -13,7 +14,7 @@ describe('GetActionPipe', () => {
1314
let getActionPipe: GetActionPipe;
1415

1516
beforeEach(() => {
16-
TestBed.configureTestingModule({ providers: [ GetActionPipe, HateoasService ]});
17+
TestBed.configureTestingModule({ providers: [GetActionPipe, HateoasService, provideZonelessChangeDetection()]});
1718
getActionPipe = TestBed.inject(GetActionPipe);
1819
});
1920

‎libs/ngrx-hateoas/src/lib/pipes/get-link.pipe.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { TestBed } from '@angular/core/testing';
22
import { HateoasService } from '../services/hateoas.service';
33
import { GetLinkPipe } from './get-link.pipe';
4+
import { provideZonelessChangeDetection } from '@angular/core';
45

56
const testModel = {
67
_links: {
@@ -13,7 +14,7 @@ describe('GetLinkPipe', () => {
1314
let getLinkPipe: GetLinkPipe;
1415

1516
beforeEach(() => {
16-
TestBed.configureTestingModule({ providers: [ GetLinkPipe, HateoasService ]});
17+
TestBed.configureTestingModule({ providers: [GetLinkPipe, HateoasService, provideZonelessChangeDetection()]});
1718
getLinkPipe = TestBed.inject(GetLinkPipe);
1819
});
1920

‎libs/ngrx-hateoas/src/lib/pipes/get-socket.pipe.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { TestBed } from '@angular/core/testing';
22
import { HateoasService } from '../services/hateoas.service';
33
import { GetSocketPipe } from './get-socket.pipe';
4+
import { provideZonelessChangeDetection } from '@angular/core';
45

56
const testModel = {
67
_sockets: {
@@ -13,7 +14,7 @@ describe('GetSocketPipe', () => {
1314
let getSocketPipe: GetSocketPipe;
1415

1516
beforeEach(() => {
16-
TestBed.configureTestingModule({ providers: [ GetSocketPipe, HateoasService ]});
17+
TestBed.configureTestingModule({ providers: [GetSocketPipe, HateoasService, provideZonelessChangeDetection()]});
1718
getSocketPipe = TestBed.inject(GetSocketPipe);
1819
});
1920

‎libs/ngrx-hateoas/src/lib/pipes/has-action.pipe.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { HasActionPipe } from './has-action.pipe';
22
import { TestBed } from '@angular/core/testing';
33
import { HateoasService } from '../services/hateoas.service';
4+
import { provideZonelessChangeDetection } from '@angular/core';
45

56
const testModel = {
67
_actions: {
@@ -13,7 +14,7 @@ describe('HasActionPipe', () => {
1314
let hasActionPipe: HasActionPipe
1415

1516
beforeEach(() => {
16-
TestBed.configureTestingModule({ providers: [ HasActionPipe, HateoasService ]});
17+
TestBed.configureTestingModule({ providers: [HasActionPipe, HateoasService, provideZonelessChangeDetection()]});
1718
hasActionPipe = TestBed.inject(HasActionPipe);
1819
});
1920

‎libs/ngrx-hateoas/src/lib/pipes/has-link.pipe.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { TestBed } from '@angular/core/testing';
22
import { HateoasService } from '../services/hateoas.service';
33
import { HasLinkPipe } from './has-link.pipe';
4+
import { provideZonelessChangeDetection } from '@angular/core';
45

56
const testModel = {
67
_links: {
@@ -13,7 +14,7 @@ describe('HasLinkPipe', () => {
1314
let hasLinkPipe: HasLinkPipe;
1415

1516
beforeEach(() => {
16-
TestBed.configureTestingModule({ providers: [ HasLinkPipe, HateoasService ]});
17+
TestBed.configureTestingModule({ providers: [HasLinkPipe, HateoasService, provideZonelessChangeDetection()]});
1718
hasLinkPipe = TestBed.inject(HasLinkPipe);
1819
});
1920

‎libs/ngrx-hateoas/src/lib/pipes/has-socket.pipe.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { TestBed } from '@angular/core/testing';
22
import { HateoasService } from '../services/hateoas.service';
33
import { HasSocketPipe } from './has-socket.pipe';
4+
import { provideZonelessChangeDetection } from '@angular/core';
45

56
const testModel = {
67
_sockets: {
@@ -13,7 +14,7 @@ describe('HasSocketPipe', () => {
1314
let hasSocketPipe: HasSocketPipe;
1415

1516
beforeEach(() => {
16-
TestBed.configureTestingModule({ providers: [ HasSocketPipe, HateoasService ]});
17+
TestBed.configureTestingModule({ providers: [HasSocketPipe, HateoasService, provideZonelessChangeDetection()]});
1718
hasSocketPipe = TestBed.inject(HasSocketPipe);
1819
});
1920

‎libs/ngrx-hateoas/src/lib/provide.spec.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { TestBed } from "@angular/core/testing";
22
import { AntiForgeryOptions, CustomHeadersOptions, HATEOAS_ANTI_FORGERY, HATEOAS_CUSTOM_HEADERS, HATEOAS_LOGIN_REDIRECT, HATEOAS_METADATA_PROVIDER, LoginRedirectOptions, MetadataProvider, provideHateoas, withAntiForgery, withCustomHeaders, withLoginRedirect, withMetadataProvider } from "./provide";
33
import { ResourceAction, ResourceLink, ResourceSocket } from "./models";
4+
import { provideZonelessChangeDetection } from "@angular/core";
45

56
describe('provideHateaos', () => {
67

@@ -17,7 +18,7 @@ describe('provideHateaos', () => {
1718
headerName: 'bar'
1819
};
1920

20-
TestBed.configureTestingModule({ providers: [ provideHateoas(withAntiForgery(dummyAntiForgeryOptions)) ]});
21+
TestBed.configureTestingModule({ providers: [provideZonelessChangeDetection(), provideHateoas(withAntiForgery(dummyAntiForgeryOptions))]});
2122
const antiForgeryOptions = TestBed.inject(HATEOAS_ANTI_FORGERY);
2223

2324
expect(antiForgeryOptions.cookieName).toBe(dummyAntiForgeryOptions.cookieName);
@@ -35,7 +36,7 @@ describe('provideHateaos', () => {
3536
redirectUrlParamName: 'bar'
3637
};
3738

38-
TestBed.configureTestingModule({ providers: [ provideHateoas(withLoginRedirect(dummyLoginRedirectOptions)) ]});
39+
TestBed.configureTestingModule({ providers: [provideZonelessChangeDetection(), provideHateoas(withLoginRedirect(dummyLoginRedirectOptions))]});
3940
const loginRedirectOptoins = TestBed.inject(HATEOAS_LOGIN_REDIRECT);
4041

4142
expect(loginRedirectOptoins.loginUrl).toBe(dummyLoginRedirectOptions.loginUrl);
@@ -54,7 +55,7 @@ describe('provideHateaos', () => {
5455
}
5556
};
5657

57-
TestBed.configureTestingModule({ providers: [ provideHateoas(withCustomHeaders(dummyCustomHeaderOptions)) ]});
58+
TestBed.configureTestingModule({ providers: [provideZonelessChangeDetection(), provideHateoas(withCustomHeaders(dummyCustomHeaderOptions))]});
5859
const customHeaderOptions = TestBed.inject(HATEOAS_CUSTOM_HEADERS);
5960

6061
expect(customHeaderOptions.headers).toBe(dummyCustomHeaderOptions.headers);
@@ -81,7 +82,7 @@ describe('provideHateaos', () => {
8182
}
8283
}
8384

84-
TestBed.configureTestingModule({ providers: [ provideHateoas(withMetadataProvider(dummyMetadataProvider)) ]});
85+
TestBed.configureTestingModule({ providers: [provideZonelessChangeDetection(), provideHateoas(withMetadataProvider(dummyMetadataProvider))]});
8586
const metadataProvider = TestBed.inject(HATEOAS_METADATA_PROVIDER);
8687

8788
expect(metadataProvider.isMetadataKey).toBe(dummyMetadataProvider.isMetadataKey);

‎libs/ngrx-hateoas/src/lib/services/hateoas.service.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { TestBed } from '@angular/core/testing';
22
import { HateoasService } from './hateoas.service';
33
import { ResourceAction, ResourceLink, ResourceSocket } from '../models';
44
import { HATEOAS_METADATA_PROVIDER, MetadataProvider } from '../provide';
5+
import { provideZonelessChangeDetection } from '@angular/core';
56

67
const dummyHateoasMetadataProvider: MetadataProvider = {
78
isMetadataKey(keyName: string) {
@@ -32,7 +33,7 @@ describe('HateoasService', () => {
3233
let hateoasService: HateoasService;
3334

3435
beforeEach(() => {
35-
TestBed.configureTestingModule({ providers: [ { provide: HATEOAS_METADATA_PROVIDER, useValue: dummyHateoasMetadataProvider }, HateoasService ]});
36+
TestBed.configureTestingModule({ providers: [{ provide: HATEOAS_METADATA_PROVIDER, useValue: dummyHateoasMetadataProvider }, HateoasService, provideZonelessChangeDetection()]});
3637
hateoasService = TestBed.inject(HateoasService);
3738
});
3839

‎libs/ngrx-hateoas/src/lib/services/request.service.spec.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { TestBed } from '@angular/core/testing';
33
import { RequestService, WINDOW } from './request.service';
44
import { provideHttpClient } from '@angular/common/http';
55
import { HttpTestingController, provideHttpClientTesting } from '@angular/common/http/testing';
6+
import { provideZonelessChangeDetection } from '@angular/core';
67

78
describe('RequestService', () => {
89

@@ -13,7 +14,7 @@ describe('RequestService', () => {
1314

1415
beforeEach(() => {
1516
TestBed.resetTestingModule();
16-
TestBed.configureTestingModule({ providers: [ RequestService, provideHttpClient(), provideHttpClientTesting() ]});
17+
TestBed.configureTestingModule({ providers: [ RequestService, provideZonelessChangeDetection(), provideHttpClient(), provideHttpClientTesting() ]});
1718
requestService = TestBed.inject(RequestService);
1819
httpTestingController = TestBed.inject(HttpTestingController);
1920
});
@@ -82,6 +83,7 @@ describe('RequestService', () => {
8283
TestBed.configureTestingModule({ providers: [
8384
RequestService,
8485
{ provide: HATEOAS_ANTI_FORGERY, useValue: antiForgeryOptions },
86+
provideZonelessChangeDetection(),
8587
provideHttpClient(),
8688
provideHttpClientTesting()
8789
]});
@@ -171,6 +173,7 @@ describe('RequestService', () => {
171173
RequestService,
172174
{ provide: WINDOW, useValue: windowsStub },
173175
{ provide: HATEOAS_LOGIN_REDIRECT, useValue: loginRedirectOptions },
176+
provideZonelessChangeDetection(),
174177
provideHttpClient(),
175178
provideHttpClientTesting()
176179
]});
@@ -250,6 +253,7 @@ describe('RequestService', () => {
250253
TestBed.configureTestingModule({ providers: [
251254
RequestService,
252255
{ provide: HATEOAS_CUSTOM_HEADERS, useValue: customHeaderOptions },
256+
provideZonelessChangeDetection(),
253257
provideHttpClient(),
254258
provideHttpClientTesting()
255259
]});
@@ -330,6 +334,7 @@ describe('RequestService', () => {
330334
TestBed.configureTestingModule({ providers: [
331335
RequestService,
332336
{ provide: HATEOAS_METADATA_PROVIDER, useValue: customMetadataProvider },
337+
provideZonelessChangeDetection(),
333338
provideHttpClient(),
334339
provideHttpClientTesting()
335340
]});

‎libs/ngrx-hateoas/src/lib/store-features/with-hypermedia-action.spec.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { withHypermediaResource } from './with-hypermedia-resource';
66
import { provideHateoas } from '../provide';
77
import { firstValueFrom, timer } from 'rxjs';
88
import { withHypermediaAction } from './with-hypermedia-action';
9+
import { provideZonelessChangeDetection } from '@angular/core';
910

1011
type TestModel = {
1112
name: string,
@@ -36,7 +37,7 @@ describe('withHypermediaAction', () => {
3637

3738
beforeEach(() => {
3839
TestBed.configureTestingModule({
39-
providers: [ provideHttpClient(), provideHttpClientTesting(), provideHateoas() ]
40+
providers: [provideZonelessChangeDetection(), provideHttpClient(), provideHttpClientTesting(), provideHateoas()]
4041
});
4142
store = TestBed.inject(TestStore);
4243
httpTestingController = TestBed.inject(HttpTestingController);
@@ -47,8 +48,6 @@ describe('withHypermediaAction', () => {
4748
expect(store.doSomethingState.method()).toBe('');
4849
expect(store.doSomethingState.isAvailable()).toBeFalse();
4950
expect(store.doSomethingState.isExecuting()).toBeFalse();
50-
expect(store.doSomethingState.hasExecutedSuccessfully()).toBeFalse();
51-
expect(store.doSomethingState.hasExecutedWithError()).toBeFalse();
5251
expect(store.doSomethingState.hasError()).toBeFalse();
5352
expect(store.doSomethingState.error()).toBeNull();
5453
});
@@ -74,8 +73,6 @@ describe('withHypermediaAction', () => {
7473
expect(store.doSomethingState.method()).toBe('PUT');
7574
expect(store.doSomethingState.isAvailable()).toBeTrue();
7675
expect(store.doSomethingState.isExecuting()).toBeFalse();
77-
expect(store.doSomethingState.hasExecutedSuccessfully()).toBeFalse();
78-
expect(store.doSomethingState.hasExecutedWithError()).toBeFalse();
7976
expect(store.doSomethingState.hasError()).toBeFalse();
8077
expect(store.doSomethingState.error()).toBeNull();
8178

@@ -85,8 +82,6 @@ describe('withHypermediaAction', () => {
8582
expect(store.doSomethingState.method()).toBe('PUT');
8683
expect(store.doSomethingState.isAvailable()).toBeTrue();
8784
expect(store.doSomethingState.isExecuting()).toBeTrue();
88-
expect(store.doSomethingState.hasExecutedSuccessfully()).toBeFalse();
89-
expect(store.doSomethingState.hasExecutedWithError()).toBeFalse();
9085
expect(store.doSomethingState.hasError()).toBeFalse();
9186
expect(store.doSomethingState.error()).toBeNull();
9287

@@ -106,8 +101,6 @@ describe('withHypermediaAction', () => {
106101
expect(store.doSomethingState.method()).toBe('PUT');
107102
expect(store.doSomethingState.isAvailable()).toBeTrue();
108103
expect(store.doSomethingState.isExecuting()).toBeFalse();
109-
expect(store.doSomethingState.hasExecutedSuccessfully()).toBeTrue();
110-
expect(store.doSomethingState.hasExecutedWithError()).toBeFalse();
111104
expect(store.doSomethingState.hasError()).toBeFalse();
112105
expect(store.doSomethingState.error()).toBeNull();
113106
});

0 commit comments

Comments
 (0)