Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native support to pass additional options to angular-compiler plugin #28458

Closed
KeM1aL opened this issue Sep 19, 2024 · 5 comments
Closed

Native support to pass additional options to angular-compiler plugin #28458

KeM1aL opened this issue Sep 19, 2024 · 5 comments

Comments

@KeM1aL
Copy link

KeM1aL commented Sep 19, 2024

Which @angular/* package(s) are relevant/related to the feature request?

compiler

Description

I would like to enable a specific option to let me build a dependency. I need to pass deprecatedAssertSyntax = true and everything should be okay ... but I can't find a way to pass that option to the esbuild angular-compiler.

Proposed solution

Allow generic section to pass options to esbuild plugins

Alternatives considered

None

@JeanMeche JeanMeche transferred this issue from angular/angular Sep 19, 2024
@clydin
Copy link
Member

clydin commented Sep 19, 2024

Can you provide additional information regarding the dependency you are trying to use? Without further information regarding the usage, enabling the ability to parse the syntax in third party libraries may not actually result in a working output.
Import assertions were never standardized and were only supported in v8 based browsers but support has since been removed. No browser officially supported by Angular can be used with an import assertion.
https://caniuse.com/mdn-javascript_statements_import_import_assertions

Would it be possible to raise an issue with the dependency to remove obsolete syntax that is not recommended for use?

@KeM1aL
Copy link
Author

KeM1aL commented Sep 20, 2024

I've created an issue in the dependency repository : reown-com/appkit#2880

But I try to find a way to use it before they release a new version including this change.

I can switch to webpack builder as I don't use ssr for now and maybe use Rules.Assert
https://webpack.js.org/configuration/module/
But I don't know how to customize my webpack config.

I don't know a solution for esbuild

@crypto-carlos
Copy link

Hm, I have the same issue now indeed, did you find a way to fix this in Angular?

@dgp1130 dgp1130 changed the title Native support to pass additionnal options to angular-compiler plugin Native support to pass additional options to angular-compiler plugin Oct 4, 2024
@alan-agius4
Copy link
Collaborator

Closing as @clydin's suggested. The best course of action is to raise an issue with the library author and address the problem upstream.

@alan-agius4 alan-agius4 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants