Skip to content

Commit f91e9e4

Browse files
committed
chore(build): clean up package.json
1 parent fb58c98 commit f91e9e4

File tree

4 files changed

+11
-20
lines changed

4 files changed

+11
-20
lines changed

ISSUE_TEMPLATE.md

+3-8
Original file line numberDiff line numberDiff line change
@@ -2,29 +2,24 @@
22
33
IMPORTANT! YOU MUST FOLLOW THESE INSTRUCTIONS OR YOUR ISSUE WILL BE CLOSED.
44
5-
Thank you for contributing to the Firebase community!
5+
Thank you for contributing to the Angular and Firebase communities!
66
77
Have a usage question?
88
=======================
9-
We get lots of those and we love helping you, but GitHub is not the best place for them and they
10-
will be closed. Here are some resources to get help:
9+
We get lots of those and we love helping you, but GitHub is not the best place for them and they will be closed. Here are some resources to get help:
1110
12-
- Start with the README: https://github.com/angular/angularfire2
1311
- Go through the Developer's Guide: https://github.com/angular/angularfire2#developer-guide
14-
- Read the full API reference: https://github.com/angular/angularfire2/blob/master/docs/api-reference.md
1512
1613
If the official documentation doesn't help, try asking through our officially supported channels:
1714
18-
- Angular Google Group: https://groups.google.com/forum/#!forum/angular
1915
- Firebase Google Group: https://groups.google.com/forum/#!forum/firebase-talk
2016
- Stack Overflow: https://stackoverflow.com/questions/tagged/angular (include the firebase and angularfire tags, too!)
2117
2218
*Please avoid double posting across multiple channels!*
2319
2420
Think you found a bug?
2521
=======================
26-
Yeah, we're definitely not perfect! Please use the bug report template below and include a minimal
27-
repro when opening the issue.
22+
Yeah, we're definitely not perfect! Please use the bug report template below and include a minimal repro when opening the issue.
2823
2924
Have a feature request?
3025
========================

PULL_REQUEST_TEMPLATE.md

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ before sending PRs. We cannot accept code without this.
2525
- Issue number for this PR: #nnn (required)
2626
- Docs included?: (yes/no; required for all API/functional changes)
2727
- Test units included?: (yes/no; required)
28-
- e2e tests included?: (yes/no; required for multi-function/multi-class changes)
2928
- In a clean directory, `npm install`, `npm run build`, and `npm test` run successfully? (yes/no; required)
3029

3130
### Description

package.json

+2-10
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,14 @@
11
{
22
"name": "angularfire2",
33
"version": "4.0.0-rc.2",
4-
"description": "",
5-
"main": "bundles/angularfire2.umd.js",
6-
"module": "index.js",
4+
"description": "The official library of Firebase and Angular.",
5+
"private": true,
76
"scripts": {
87
"test": "karma start --single-run",
98
"test:watch": "concurrently \"npm run build:watch\" \"npm run delayed_karma\"",
109
"test:debug": "npm run build && karma start",
1110
"delayed_karma": "sleep 10 && karma start",
12-
"delayed_rollup": "sleep 5 && rollup --watch -c rollup.test.config.js",
13-
"build:watch": "rm -rf dist && concurrently \"tsc -w\" \"npm run delayed_rollup\"",
1411
"build": "rm -rf dist && node tools/build.js",
15-
"build_npm": "rm -rf dist && ngc -p tsconfig.publish.es6.json && rollup -c rollup.publish.config.js && npm run postbuild_npm",
16-
"build_e2e": "rm -rf dist-test && npm run build && tsc -p test/ && cp test/e2e/firebase_object/index.html dist-test/e2e/firebase_object/ && cp test/e2e/firebase_list/index.html dist-test/e2e/firebase_list/ && cp test/e2e/auth/index.html dist-test/e2e/auth/",
17-
"postbuild_npm": "cp package.json README.md .npmignore dist/ && npm run rewrite_npm_package",
18-
"rewrite_npm_package": "node tools/rewrite-published-package.js",
19-
"e2e_test": "webdriver-manager update && npm run build_e2e && protractor",
2012
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s -r 1"
2113
},
2214
"keywords": [

tools/build.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,10 @@ function copyNpmIgnore() {
187187
return copy(`${process.cwd()}/.npmignore`, `${process.cwd()}/dist/packages-dist/.npmignore`);
188188
}
189189

190+
function copyReadme() {
191+
return copy(`${process.cwd()}/README.md`, `${process.cwd()}/dist/packages-dist/README.md`);
192+
}
193+
190194
function measure(module, gzip = true) {
191195
const path = `${process.cwd()}/dist/packages-dist/bundles/${module}.umd.js`;
192196
const file = readFileSync(path);
@@ -230,7 +234,8 @@ function buildLibrary(globals) {
230234
return Observable
231235
.forkJoin(modules$)
232236
.switchMap(() => Observable.from(createTestUmd(globals)))
233-
.switchMap(() => Observable.from(copyNpmIgnore()));
237+
.switchMap(() => Observable.from(copyNpmIgnore()))
238+
.switchMap(() => Observable.from(copyReadme()));
234239
}
235240

236241
buildLibrary(GLOBALS).subscribe(

0 commit comments

Comments
 (0)