Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use INumberBase<T>.CreateChecked on .NET 7+ #1518

Conversation

andrewimcclement
Copy link

Implementing change suggested in #1483 .

@andrewimcclement andrewimcclement changed the title Aim/issue1483 create checked Use INumberBase<T>.CreateChecked on .NET 7+ Feb 26, 2025
@lipchev
Copy link
Collaborator

lipchev commented Feb 26, 2025

I don't personally use these extensions, but here are a few more remarks:

@andrewimcclement
Copy link
Author

Using IConvertible does avoid the boxing, which is nice.

Copy link
Collaborator

@lipchev lipchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Hopefully, one day we would be able to add the properties here as well..

@angularsen angularsen merged commit 80ce17c into angularsen:release/v6 Mar 4, 2025
1 check passed
@angularsen
Copy link
Owner

Looks good to me also, thanks!

@lipchev you can also merge PRs by the way unless you want a pair of extra eyes on it.
I'll probably look over it anyways, but no need to wait for me.

@lipchev
Copy link
Collaborator

lipchev commented Mar 4, 2025

@angularsen I know, but I didn't know how you want to handle the release of this one, and the merging of the changes between master and release-v6..

@andrewimcclement andrewimcclement deleted the aim/issue1483-create-checked branch March 4, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants