-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use INumberBase<T>.CreateChecked on .NET 7+ #1518
Use INumberBase<T>.CreateChecked on .NET 7+ #1518
Conversation
I don't personally use these extensions, but here are a few more remarks:
|
…m to any issue with `<Nullable>enable</Nullable>`and `<LangVersion>latest</LangVersion>`.
Using IConvertible does avoid the boxing, which is nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hopefully, one day we would be able to add the properties here as well..
Looks good to me also, thanks! @lipchev you can also merge PRs by the way unless you want a pair of extra eyes on it. |
@angularsen I know, but I didn't know how you want to handle the release of this one, and the merging of the changes between |
Implementing change suggested in #1483 .