Run the build on JDK 21 and fix what detekt then found

gradle/gradle-daemon-jvm.properties pinned the daemon to JDK 25, so every build
ran there whatever JAVA_HOME said. detekt 1.23 embeds a Kotlin compiler that
cannot parse a 25.x version string and died with 'IllegalArgumentException:
25.0.3' before analysing anything, which is what failed CI.

Dropping the generated toolchainUrl entries with it: they pointed at JDK 25
downloads and would be wrong for a 21 request. Gradle now uses the locally
installed 21 that dev machines and the runner already have.

With detekt actually running, three real findings surfaced and one config bug:

- BADGE_ALPHA and BORDER_ALPHA in UrgencyStyle.kt were dead
- MagicNumber listed excludes, which replaces detekt's defaults instead of
  adding to them, so the test sources lost their exemption and 55 deliberate
  literals in tests were flagged
- parseIsoish trips ReturnCount at 7 returns, all of them guard clauses, which
  is the house style; guards are no longer counted

Also renames UrgencyBadge.kt to UrgencyStyle.kt. It holds no UrgencyBadge, which
ktlint's filename rule caught and which had been failing since the file was
written.

Author: anish-sahoo

build.gradle.kts

@@ -22,6 +22,14 @@ allprojects {
         config.setFrom(rootProject.files("config/detekt/detekt.yml"))
         parallel = true
     }
+
+    // detekt 1.23 embeds a Kotlin compiler whose IntelliJ `JavaVersion.parse` cannot read a
+    // JDK 25 version string, and dies with `IllegalArgumentException: 25.0.3` before it
+    // analyses anything. The task has no `javaLauncher`, so the JVM is pinned in
+    // gradle.properties instead. This only sets the bytecode target.
+    tasks.withType<io.gitlab.arturbosch.detekt.Detekt>().configureEach {
+        jvmTarget = "21"
+    }
 }
 
 /**

…irydatereminder/ui/items/UrgencyBadge.kt …irydatereminder/ui/items/UrgencyStyle.ktcomposeApp/src/main/kotlin/com/anish/expirydatereminder/ui/items/UrgencyBadge.kt renamed to composeApp/src/main/kotlin/com/anish/expirydatereminder/ui/items/UrgencyStyle.kt composeApp/src/main/kotlin/com/anish/expirydatereminder/ui/items/UrgencyBadge.kt renamed to composeApp/src/main/kotlin/com/anish/expirydatereminder/ui/items/UrgencyStyle.kt

@@ -51,6 +51,3 @@ fun urgencyStyle(status: ExpiryStatus): UrgencyStyle {
         )
     }
 }
-
-private const val BADGE_ALPHA = 0.10f
-private const val BORDER_ALPHA = 0.22f

config/detekt/detekt.yml

@@ -13,7 +13,7 @@ naming:
     ignoreAnnotated: ['Composable']
   MatchingDeclarationName:
     # Several files deliberately group a component with the small types that only it uses
-    # (SystemCamera.kt/CameraCapture, UrgencyBadge.kt/UrgencyStyle). One file per declaration
+    # (SystemCamera.kt/CameraCapture). One file per declaration
     # would scatter them.
     active: false
 
@@ -37,13 +37,21 @@ style:
     # :shared — the database, migration and parser code, where a bare literal is a real risk.
     ignoreAnnotated: ['Composable']
     ignorePropertyDeclaration: true
+    # Listing excludes replaces detekt's defaults rather than adding to them, which is how
+    # the test source sets ended up in scope. Tests are full of deliberate literals — dates,
+    # day counts, row ids — and naming each one hides what the case is actually about.
     excludes:
       - '**/ui/**'
       - '**/widget/**'
+      - '**/test/**'
+      - '**/androidTest/**'
+      - '**/commonTest/**'
   MaxLineLength:
     # Matches .editorconfig, so ktlint and detekt agree.
     maxLineLength: 120
   ReturnCount:
     # Guard clauses and early returns are the house style; a parser that validates five
-    # fields in sequence reads better as five early returns than as nested ifs.
+    # fields in sequence reads better as five early returns than as nested ifs, so the
+    # guards are not counted against the limit at all.
     max: 6
+    excludeGuardClauses: true

gradle/gradle-daemon-jvm.properties

@@ -1,12 +1,8 @@
-#This file is generated by updateDaemonJvm
-toolchainUrl.FREE_BSD.AARCH64=https\://api.foojay.io/disco/v3.0/ids/cf726b4a1c84b50457225f9bba6d7650/redirect
-toolchainUrl.FREE_BSD.X86_64=https\://api.foojay.io/disco/v3.0/ids/fa1e318c287360478e3c83a9a3ef1007/redirect
-toolchainUrl.LINUX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/cf726b4a1c84b50457225f9bba6d7650/redirect
-toolchainUrl.LINUX.X86_64=https\://api.foojay.io/disco/v3.0/ids/fa1e318c287360478e3c83a9a3ef1007/redirect
-toolchainUrl.MAC_OS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/c2dd35c9d0aaf0ba6ad0791320f99dfc/redirect
-toolchainUrl.MAC_OS.X86_64=https\://api.foojay.io/disco/v3.0/ids/e5810bd7fd1f8a586644409d395a7e55/redirect
-toolchainUrl.UNIX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/cf726b4a1c84b50457225f9bba6d7650/redirect
-toolchainUrl.UNIX.X86_64=https\://api.foojay.io/disco/v3.0/ids/fa1e318c287360478e3c83a9a3ef1007/redirect
-toolchainUrl.WINDOWS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/7b3c4877c0749019e6805bb61e421497/redirect
-toolchainUrl.WINDOWS.X86_64=https\://api.foojay.io/disco/v3.0/ids/d76df094a9cbbabd3b08251f9e61444a/redirect
-toolchainVersion=25
+# The JVM the Gradle daemon itself runs on, which is not the same thing as the JVM the
+# code targets. This said 25, so every build ran on JDK 25 whatever JAVA_HOME pointed at,
+# and detekt 1.23 dies on a version string that new before it analyses anything.
+#
+# The generated toolchainUrl entries are gone with it. They pointed at JDK 25 downloads
+# and would be wrong for a 21 request. Without them Gradle uses a locally installed 21,
+# which is what both a dev machine and the CI runner already have.
+toolchainVersion=21