Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add required changes to docusaurus present in /docs #115

Open
ashwinijha6 opened this issue Mar 8, 2021 · 9 comments
Open

fix: add required changes to docusaurus present in /docs #115

ashwinijha6 opened this issue Mar 8, 2021 · 9 comments
Labels

Comments

@ashwinijha6
Copy link

Is your feature request related to a problem? Please describe.

Certain changes are required in docusaurus present in the /docs directory

  • Add the command npm run serve wherever required one can refer this.
  • The .features & .featureImage is not required, should be removed from here.
  • As the open source programs backend docusaurus has been published the link should be changed in docusaurus.config.js

Describe the solution you'd like

  • npm run serve will help checking with the local build during change
  • The 2 features mentioned above are not required
  • Correct link should be mentioned

Additional context

npm
feature_not_required
doc_backend

@ashwinijha6
Copy link
Author

@codesankalp & @keshakaneria could u'll pls check this issue & add necessary labels . Also if it is valid I would like to work on it.

@keshakaneria
Copy link
Member

In the footer, the 'Backend docs' needs to have the same link which is there currently, i guess. But yes, the npm run serve and unwanted .css can be removed from the file.

@keshakaneria keshakaneria added the Type: Bug Bug or Bug fixes. label Mar 9, 2021
@ashwinijha6
Copy link
Author

In the footer, the 'Backend docs' needs to have the same link which is there currently, i guess. But yes, the npm run serve and unwanted .css can be removed from the file.

No @keshakaneria we have migrated the docs to docusaurus for backend & web separately but the web was merged before the backend that's why the link needs to be changed in the Backend docs mentioned in the footer to this currently it is the wiki link.

@keshakaneria
Copy link
Member

In the footer, the 'Backend docs' needs to have the same link which is there currently, i guess. But yes, the npm run serve and unwanted .css can be removed from the file.

No @keshakaneria we have migrated the docs to docusaurus for backend & web separately but the web was merged before the backend that's why the link needs to be changed in the Backend docs mentioned in the footer to this currently it is the wiki link.

Oh yes I'm sorry I forgot we separated them 🤦‍♀️ Yes the link need to be changed! You can go ahead solving this issue 👍😄

@ashwinijha6
Copy link
Author

Hey @keshakaneria should I also change the repo name to anitab-forms-web wherever required or we can keep as another issue like may be a first timers only. What say?

@keshakaneria
Copy link
Member

Hey @keshakaneria should I also change the repo name to anitab-forms-web wherever required or we can keep as another issue like may be a first timers only. What say?

The issue is already created and a PR is also under review. You will have to change the name according to it otherwise while merging it will show conflicts.

@ashwinijha6
Copy link
Author

Hey @keshakaneria should I also change the repo name to anitab-forms-web wherever required or we can keep as another issue like may be a first timers only. What say?

The issue is already created and a PR is also under review. You will have to change the name according to it otherwise while merging it will show conflicts.

Yes I found that @keshakaneria I have not changed the repo name here in this PR. I'll let that be done in the that PR only will make review wherever necessary 👍

@isabelcosta isabelcosta added Hacktoberfest Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Oct 3, 2021
@isabelcosta
Copy link
Member

@nlok5923 would you like to contribute to this one?
cc @codesankalp

@nlok5923
Copy link
Contributor

nlok5923 commented Oct 9, 2021

Thanks @isabelcosta for picking issue for me i would like to give it a try.

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants