Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add GET endpoint /users/{userId}/personal-background to fetch personal background from userId #216

Closed
Rahulm2310 opened this issue Mar 12, 2021 · 11 comments · Fixed by #268
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Type: Enhancement New feature or request.

Comments

@Rahulm2310
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Although we have endpoint /personal-background for a to fetch personal background details of current user (using access_token). We don't have endpoint for a user (org representative) requesting personal background of other user.

Describe the solution you'd like

There should be a GET endpoint /users/{userId}/personal-background for fetching a user's personal background details from userId.

Additional context

Refer to the discussion here.

@mtreacy002 mtreacy002 added the Category: Coding Changes to code base or refactored code that doesn't fix a bug. label Mar 12, 2021
@mtreacy002
Copy link
Member

Thank you for raising this issue, @Rahulm2310 . Let me know which one of #215 / #216 you want to work on. I'll assign you to what you choose and make the other available.

@mtreacy002 mtreacy002 added the Type: Enhancement New feature or request. label Mar 12, 2021
@harsh7in
Copy link

@mtreacy002 can i work on this?

@mtreacy002
Copy link
Member

Sure, @harsh-9in , I'll assign you on this. @Rahulm2310 , do you want to pick the other one or should I make it available?

@harsh7in
Copy link

Thanks, @mtreacy002, I am working on this issue.

@Rahulm2310
Copy link
Contributor Author

@harsh-9in Can you please share your progress on this ?

@devkapilbansal
Copy link
Member

Unassigning @harsh-9in due to lack of response.

@jalajcodes
Copy link
Member

jalajcodes commented Mar 30, 2021

Making it available for OSH.

@jalajcodes jalajcodes added Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Mar 30, 2021
@meganbader
Copy link
Contributor

Can I work on this issue?

@epicadk epicadk removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 17, 2021
@meganbader
Copy link
Contributor

Should we only get the user's info if it is public? or does that not matter?

@jalajcodes
Copy link
Member

Should we only get the user's info if it is public? or does that not matter?

Getting public info makes more sense, although I am not sure.. cc @mtreacy002

@mtreacy002
Copy link
Member

mtreacy002 commented Apr 18, 2021

You're correct, @meganbader , we only can return user info if the user opted to have their personal info shared publicly. So if it's not, then the organization representative or other users shouldn't be able to see this. There are certain scenarios that the system can return any user info (like when we want to show analysis of users in mentoring programs based on personal background categories), but the viewers of this data analysis cannot see the details of which user falls into the specific category. Hope this makes sense 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Type: Enhancement New feature or request.
Projects
None yet
7 participants