-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA: Add a code formatter and code linter for standardizing the code style #174
Comments
@mtreacy002 @isabelcosta Is this valid? If yes, I would like to work on this. Thanks 🙂 |
@Rahulm2310 . I think this is a valid issue. Can you please tell me which of the 2 you mentioned above you're going to use? Can you please share your insight on pros and cons on both options here? Thanks |
@mtreacy002 We can use integrate both of them to get the best results (a new trend). Prettier also provides a guide to integrate with eslint. |
Sounds good to me (to integrate both), @Rahulm2310 . The next question is, how and when will we apply the linters? Can they be added to the CI build (currently we're using Travis but soon moving to Github action) which is an ideal way so no need for manual linting. |
Yes @mtreacy002 . Both of these can be added to Github Actions to avoid manual linting. But should we put this on hold till we use Travis ? |
Definitely, @Rahulm2310. In fact, we're moving to Github Actions, so once #170 approved and merged, you can work on this issue and add the linters as GitHub workflow 😉 |
Sure. Thanks @mtreacy002 😉 |
@Rahulm2310 , I forgot that there's a black linter issue that will address this as part of github workfkow. I'll close this issue now to avoid duplication 😉 |
@mtreacy002 Isn't that for backend? We need a linter for frontend as well |
Oops, you're right, @Rahulm2310 . Sorry for the confusion. Reopening this again 😊. |
hi @Mtreacy . can i work on this issue |
@satyaarthchhabra hey are you still interested to work on this? |
@vj-codes I would like yo work on this issue |
Assigning you @ritik307 |
Is your feature request related to a problem? Please describe.
It will be difficult to enforce a coding style as the repo grows bigger and gets more PRs.
Describe the solution you'd like
We must use a code formatter (ideally, opinionated one like https://prettier.io/) and a code linter (like https://eslint.org/) to enhance code quality and maintain consistency.
The text was updated successfully, but these errors were encountered: