Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Remove warnings when running npm test #195

Open
mtreacy002 opened this issue Mar 10, 2021 · 12 comments
Open

Test: Remove warnings when running npm test #195

mtreacy002 opened this issue Mar 10, 2021 · 12 comments
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Testing UI Tests, Integration Tests, Travis CI, etc.

Comments

@mtreacy002
Copy link
Member

Describe the bug

On the existing code, although the npm test runs successfully (all 3 tests passed), there are warnings shown on Register.test.js and PersonalDetails.test.js.

To Reproduce

Steps to reproduce the behavior:

  1. run npm test
  2. see errors

Expected behavior

Tests should run without errors

Screenshots

Here's the gist from the console log

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: NA
  • IDE: VS Code
  • Shell: cmd

Additional context

NA

@mtreacy002 mtreacy002 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Testing UI Tests, Integration Tests, Travis CI, etc. labels Mar 10, 2021
@HeroicHitesh
Copy link
Member

@mtreacy002 I would like to work on this

@mtreacy002
Copy link
Member Author

Sure, @HeroicHitesh . Assigning you now.

@mtreacy002 mtreacy002 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 13, 2021
@Amulya-coder
Copy link
Member

@HeroicHitesh this issue is good for Open Source hack can we give chance to other contributors to work on this during OSH, what you think?

@HeroicHitesh
Copy link
Member

@Amulya-coder Sure

@HeroicHitesh HeroicHitesh removed their assignment Mar 18, 2021
@Amulya-coder Amulya-coder added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 18, 2021
@HarshKumarChoudary
Copy link

I would like to work on this issue? Please assign it to me. Also I want to know is there any defined time limit in which I had to finish this work.

@HeroicHitesh
Copy link
Member

@HarshKumarChoudary Please reply with an answer to these questions

  1. Have you completed the setup of the project mentioned in Task: Set up local environment #218? If no, please setup the project first.
  2. Are you assigned to any other issue currently? If yes, please work on that first.

Also I want to know is there any defined time limit in which I had to finish this work.

There is no time limit for contribution but to be considered in OSH it should be completed in April only. Also, it is required to provide an update on your progress after every 3 days.

Let me know if you have any other doubts. Have a good time during OSH👍

@HarshKumarChoudary
Copy link

I will complete the setup of project by tomorrow.
Also I was assigned an issue but I had submitted PR for it and it is not yet merged. May be it I will get any response by today.

@HeroicHitesh
Copy link
Member

I will complete the setup of project by tomorrow.

Ok @HarshKumarChoudary, but that's a prerequisite so please complete that first and then ask for the issue assignment.

Also I was assigned an issue but I had submitted PR for it and it is not yet merged. May be it I will get any response by today.

I have reviewed and requested some changes to your PR. It is recommended to wait for 2 approvals on your PR before moving on to new issues.

@Anmollenka
Copy link

I would like to work on this issue.

@mtreacy002
Copy link
Member Author

@Anmollenka , you can come back to claim this issue after you complete #194 😉

@naveen8801
Copy link
Contributor

Hey @mtreacy002, I'd like to work on this, please assign 😃

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Aug 22, 2021
@isabelcosta
Copy link
Member

I just assigned to you @naveen8801 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
Development

No branches or pull requests

7 participants