Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1196 ✔️ Added description on dependency download in Android Studio #1214

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixes #1196 ✔️ Added description on dependency download in Android Studio #1214

wants to merge 3 commits into from

Conversation

pratyaksh1610
Copy link

@pratyaksh1610 pratyaksh1610 commented Jul 14, 2022 •
edited
Loading

Description

Fixes #1196
Added description on dependency download in Android Studio.

a1
a2

Type of Change:

  • Documentation

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have made corresponding changes to the documentation

tinniaru3005
tinniaru3005 reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@tinniaru3005 tinniaru3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a screenshot in the PR comment showing the changes you made. Otherwise, it looks good to me. Thanks for contributing. :)

@pratyaksh1610
Copy link
Author

@tinniaru3005 added the screenshots. Pls review.

tinniaru3005
tinniaru3005 reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@tinniaru3005 tinniaru3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pratyaksh1610 . Congratulations on making a PR to the project. Thanks for adding the screenshot. The changes are fine. Thanks for contributing. If you have any further doubts you can reach us at zulip chat :)

@pratyaksh1610
Copy link
Author

pratyaksh1610 commented Jul 15, 2022 •
edited
Loading

Why these checks are failing ? some of them, or it requires another person's review

@tinniaru3005
Copy link
Member

Why these checks are failing ? some of them, or it requires another person's review

Well, I don't have much idea regarding that. You can ask your doubts at zulip chat and the admins can help you with that. But for Open Souce Hack it is not necessary to get your PRs merged. :)

@pratyaksh1610
Copy link
Author

But I think PR is required to be merged as it is part of documentation , and for a project , a clear and concise documentation is much needed.

@pratyaksh1610
Copy link
Author

@isabelcosta Please review this PR, so that it can be merged.
.
.
Thankyou
Pratyaksh

@pratyaksh1610
Copy link
Author

@vj-codes Pls review this PR so that it can be merged.
.
.
Thankyou
Pratyaksh

@pratyaksh1610
Copy link
Author

@vj-codes @vatsalkul Please review this PR so that it can be merged.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinniaru3005 tinniaru3005 tinniaru3005 left review comments

@isabelcosta isabelcosta Awaiting requested review from isabelcosta isabelcosta is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Description on dependency download
2 participants
@pratyaksh1610 @tinniaru3005