Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change feedback page text color #1203

Closed
wants to merge 2 commits into from

Conversation

pypas
Copy link

@pypas pypas commented Jul 6, 2022

Description

Change the colour of "Send us your feedback!" on the Feedback page from black to #55111109

Fixes #1200

Type of Change:

  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

image

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@pypas pypas requested a review from isabelcosta as a code owner July 6, 2022 16:37
@tinniaru3005 tinniaru3005 self-requested a review July 6, 2022 16:59
Copy link
Member

@tinniaru3005 tinniaru3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pypas . Thanks for making the changes. I wanted the 'Send us your feedback!' text colour to be the same as the background of the header just above it (violet: colour code of that is #55111109 I guess but you can confirm that). But according to the screenshot you shared the text colour is greyish. Can you please make the change and then I can approve it :)

@pypas
Copy link
Author

pypas commented Jul 7, 2022

Hi @tinniaru3005, I've updated the color as requested!

@pypas pypas requested a review from tinniaru3005 July 7, 2022 06:06
Copy link
Member

@tinniaru3005 tinniaru3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pypas . Thanks for making the changes. The changes are fine. Congratulations! :)

@pypas pypas closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback page text color change
2 participants