Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default currency for Countries #97

Open
shreyashah115 opened this issue Jan 20, 2022 · 1 comment
Open

Default currency for Countries #97

shreyashah115 opened this issue Jan 20, 2022 · 1 comment
Labels

Comments

@shreyashah115
Copy link

shreyashah115 commented Jan 20, 2022

Is there a way to add a default/ official currency for all countries?

Example, Switzerland has its official currency as CHF but in the currency array we have ['CHE', 'CHF', 'CHW'], either we can change the alphabetical order of array to have the official currency listed as first ['CHF', 'CHE', 'CHW'] or introduce a new field to only have the official one? This would help in cases where we need to show one of the currencies in form options based on country.

@dmythro
Copy link
Member

dmythro commented May 9, 2022

So, there's like 6 countries which have more than 1 currency. And one of them is not sorted A-Z, the rest are.
I think you're right, it's better to check all of them manually and fix the order to have first one as main official currency. Will do that with next release @shreyashah115.

image

But next release will be a major one and have a few breaking changes, as it will utilise couple new data structures and completely move to TypeScript for code, utils etc. Currencies is an array of string there now instead of a comma-separated string, by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants