Merge pull request #19 from rawveg/nullable_dates

Added null check for dates, along with tests

Author: Gman98ish

src/Filters/DateFilter.php

@@ -10,10 +10,18 @@ class DateFilter implements ModifiesQueries
     public function modifyQuery($query, SearchTerm $search)
     {
         if ($search->operator() == 'eq') {
-            $query->where($search->column(), $search->term());
+            if ($search->term() == 'null') {
+                $query->whereNull($search->column());
+            } else {
+                $query->where($search->column(), $search->term());
+            }
         }
         if ($search->operator() == 'neq') {
-            $query->where($search->column(), '!=', $search->term());
+            if ($search->term() == 'null') {
+                $query->whereNotNull($search->column());
+            } else {
+                $query->where($search->column(), '!=', $search->term());
+            }
         }
         if ($search->operator() == 'in') {
             $query->whereIn($search->column(), explode(',', $search->term()));

tests/Filters/DateFilterTest.php

@@ -18,7 +18,7 @@ public function can_filter_by_eq()
 
         $this->assertEquals(
             "select * from `pets` where `created_at` = ?",
-            $query->toSql(),
+            $query->toSql()
         );
     }
 
@@ -32,7 +32,7 @@ public function can_filter_by_neq()
 
         $this->assertEquals(
             "select * from `pets` where `created_at` != ?",
-            $query->toSql(),
+            $query->toSql()
         );
     }
 
@@ -51,7 +51,7 @@ public function can_filter_by_in()
 
         $this->assertEquals(
             "select * from `pets` where `created_at` in (?, ?, ?)",
-            $query->toSql(),
+            $query->toSql()
         );
     }
 
@@ -70,7 +70,7 @@ public function can_filter_by_nin()
 
         $this->assertEquals(
             "select * from `pets` where `created_at` not in (?, ?, ?)",
-            $query->toSql(),
+            $query->toSql()
         );
     }
 
@@ -84,7 +84,7 @@ public function can_filter_by_lt()
 
         $this->assertEquals(
             "select * from `pets` where `created_at` < ?",
-            $query->toSql(),
+            $query->toSql()
         );
     }
 
@@ -98,7 +98,35 @@ public function can_filter_by_gt()
 
         $this->assertEquals(
             "select * from `pets` where `created_at` > ?",
-            $query->toSql(),
+            $query->toSql()
+        );
+    }
+
+    /**
+     * @test
+     */
+    public function can_filter_null_by_eq()
+    {
+        $query = Pet::query()->getQuery();
+        (new DateFilter)->modifyQuery($query, $this->searchTerm('eq', 'null'));
+
+        $this->assertEquals(
+            "select * from `pets` where `created_at` is null",
+            $query->toSql()
+        );
+    }
+
+    /**
+     * @test
+     */
+    public function can_filter_null_by_neq()
+    {
+        $query = Pet::query()->getQuery();
+        (new DateFilter)->modifyQuery($query, $this->searchTerm('neq', 'null'));
+
+        $this->assertEquals(
+            "select * from `pets` where `created_at` is not null",
+            $query->toSql()
         );
     }
 

tests/Filters/EnumFilterTest.php

@@ -43,7 +43,7 @@ public function can_search_if_passed_a_valid_term()
 
         $this->assertEquals(
             'select * from "pets" where "letter" = ?',
-            $query->toSql(),
+            $query->toSql()
         );
     }
 }