Factor RTTI type name pretty printing out of dump.cc.

It's useful in impedance module as well.

Author: anse1

dump.cc

@@ -1,25 +1,15 @@
-#include <typeinfo>
 #include <string>
 #include <sstream>
 
 #include "dump.hh"
+#include "util.hh"
 
 using namespace std;
 
-std::string graphml_dumper::type(struct prod *p)
-{
-  ostringstream os;
-  os << typeid(*p).name();
-  string s = os.str();
-  while(s[0] <= '9')
-    s.erase(s.begin());
-  return s;
-}
-
 std::string graphml_dumper::id(struct prod *p)
 {
   ostringstream os;
-  os << type(p) << "_" << p;
+  os << pretty_type(p) << "_" << p;
   return os.str();
 }
 
@@ -47,7 +37,7 @@ void graphml_dumper::visit(struct prod *p)
 {
   o << "<node id=\"" << id(p) <<  "\">";
   o << "<data key=\"retries\">" << p->retries << "</data>";
-  o << "<data key=\"label\">" << type(p) << "</data>";
+  o << "<data key=\"label\">" << pretty_type(p) << "</data>";
   o << "<data key=\"scope\">" << p->scope << "</data>";
   o << "</node>" << endl;
   if (p->pprod) {

impedance.cc

@@ -49,7 +49,7 @@ void report()
 {
   cerr << "impedance report: " << endl;
   for (auto pair : occurances_in_failed_query) {
-    cerr << "  " << pair.first << ": " <<
+    cerr << "  " << pretty_type(pair.first) << ": " <<
       pair.second << "/" << occurances_in_ok_query[pair.first]
 	 << " (bad/ok)";
     if (!matched(pair.first))

impedance.hh

@@ -8,6 +8,7 @@
 #include <typeinfo>
 #include <map>
 #include "prod.hh"
+#include "util.hh"
 #include "log.hh"
 
 struct impedance_visitor : prod_visitor {

util.hh

@@ -0,0 +1,24 @@
+#ifndef UTIL_HH
+#define UTIL_HH
+#include <typeinfo>
+#include <string>
+#include <sstream>
+
+using namespace std;
+
+inline std::string pretty_type(const char *raw)
+{
+  ostringstream os;
+  os << raw;
+  string s = os.str();
+  while(s[0] <= '9')
+    s.erase(s.begin());
+  return s;
+}
+
+inline std::string pretty_type(struct prod *p)
+{
+  return pretty_type(typeid(*p).name());
+}
+
+#endif