From b236621774885b307e0471e328432bd0f0d96683 Mon Sep 17 00:00:00 2001 From: cord Date: Fri, 22 Aug 2025 16:25:00 -0600 Subject: [PATCH 1/3] adding test to expand coverage of nurbs sketching --- tests/test_sketch.py | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/tests/test_sketch.py b/tests/test_sketch.py index e661323c60..0c38ec3d81 100644 --- a/tests/test_sketch.py +++ b/tests/test_sketch.py @@ -48,6 +48,7 @@ Slot, SpurGear, Triangle, + nurbs, ) from .conftest import are_graphics_available @@ -369,6 +370,31 @@ def test_sketch_nurbs(): assert not sketch.edges[0].contains_point(Point2D([5, 5])) +def test_sketch_nurbs_misc(): + """Test NURBS Sketch for code coverage""" + control_points = [ + Point2D([0.0, 0.0]), + Point2D([1.0, 2.0]), + Point2D([2.0, 0.0]), + Point2D([3.0, 3.0]), + ] + # Checking geomdl_nurbs_curve usage + nurbs_curve = nurbs.SketchNurbs.fit_curve_from_points(points=control_points, degree=3) + assert nurbs_curve.geomdl_nurbs_curve.ctrlpts[0][0] == 0.0 + # Checking value error for degrees less than 1 + with pytest.raises( + ValueError, + match="Degree must be at least 1", + ): + nurbs.SketchNurbs.fit_curve_from_points(points=control_points, degree=0) + # Checking Force linear interpolation + control_points = [ + Point2D([0.0, 0.0]), + Point2D([1.0, 1.0]), + ] + nurbs_curve = nurbs.SketchNurbs.fit_curve_from_points(points=control_points) + + def test_sketch_triangle_face(): """Test Triangle SketchFace sketching.""" # Create a Sketch instance From ada3c01603c66d1c3bfd306ec7178052747fe9bf Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Fri, 22 Aug 2025 22:27:46 +0000 Subject: [PATCH 2/3] chore: adding changelog file 2193.test.md [dependabot-skip] --- doc/changelog.d/2193.test.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/2193.test.md diff --git a/doc/changelog.d/2193.test.md b/doc/changelog.d/2193.test.md new file mode 100644 index 0000000000..5752b5bffb --- /dev/null +++ b/doc/changelog.d/2193.test.md @@ -0,0 +1 @@ +Adding test for nurbs sketching From 6e5a6225624d475cb86b83bc8f4ac34e5c9ac22c Mon Sep 17 00:00:00 2001 From: cord Date: Tue, 26 Aug 2025 11:30:29 -0600 Subject: [PATCH 3/3] adding validation to end of test --- tests/test_sketch.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test_sketch.py b/tests/test_sketch.py index 0c38ec3d81..f79dc1ae8e 100644 --- a/tests/test_sketch.py +++ b/tests/test_sketch.py @@ -393,6 +393,8 @@ def test_sketch_nurbs_misc(): Point2D([1.0, 1.0]), ] nurbs_curve = nurbs.SketchNurbs.fit_curve_from_points(points=control_points) + assert nurbs_curve.control_points[0].x == 0.0 + assert nurbs_curve.degree == 1 def test_sketch_triangle_face():