Skip to content

chore: v1 implementation of file/designs stub #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacobrkerstetter merged 32 commits into from
Dec 8, 2025
Merged

chore: v1 implementation of file/designs stub #2443

jacobrkerstetter merged 32 commits into from
Dec 8, 2025

Conversation

@jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Dec 4, 2025

Description

As title says
Methods related to opening, saving, and inserting files
Other various fixes to get tests running properly

Issue linked

Related to #2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

b-matteo and others added 11 commits December 1, 2025 16:19
@b-matteo
First push of designs v1 implementation
f62b2e0
@jacobrkerstetter
wip
dcb6aad
@jacobrkerstetter
improvements to design import/export
3f2be02
@jacobrkerstetter
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
aaba488 
… chore/v1_implementation_of_file_stub

# Conflicts:
#	src/ansys/geometry/core/_grpc/_services/v1/conversions.py
#	src/ansys/geometry/core/_grpc/_services/v1/parts.py
@jacobrkerstetter
fixing small issues in materials and points to get v1 tests running
561e913
@b-matteo
Update pyproject.toml
43e89d9
@jacobrkerstetter
open_file fully working, insert not working
b3f744d
@jacobrkerstetter
fixed frame conversion
6e6be14 
impl full design tessellation streaming
@jacobrkerstetter
minor fixes in command_script
f36baf5 
implementing open_file, save, and insert and routing v1 calls to them
tests that require the use of uploading garbage files are checking for errors thrown
@jacobrkerstetter
fixing if statements to run correct versions
cba23e2
@jacobrkerstetter
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
dc431dc 
… chore/v1_implementation_of_file_stub
@jacobrkerstetter jacobrkerstetter self-assigned this Dec 4, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner December 4, 2025 18:34
@codecov
Copy link

codecov bot commented Dec 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 43.80952% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.41%. Comparing base (faf079a) to head (e16e837).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v1/conversions.py 13.79% 25 Missing ⚠️
src/ansys/geometry/core/misc/auxiliary.py 13.33% 13 Missing ⚠️
src/ansys/geometry/core/modeler.py 75.00% 9 Missing ⚠️
src/ansys/geometry/core/designer/design.py 50.00% 6 Missing ⚠️
...nsys/geometry/core/_grpc/_services/v1/materials.py 0.00% 4 Missing ⚠️
...sys/geometry/core/_grpc/_services/v1/components.py 0.00% 1 Missing ⚠️
src/ansys/geometry/core/misc/options.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
- Coverage   90.65%   90.41%   -0.24%     
==========================================
  Files         169      169              
  Lines       12047    12098      +51     
==========================================
+ Hits        10921    10939      +18     
- Misses       1126     1159      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter mentioned this pull request Dec 4, 2025
Open
23 tasks
RobPasMue
RobPasMue reviewed Dec 7, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments - tremendous cleanup @jacobrkerstetter on failing tests for v1

RobPasMue
RobPasMue previously approved these changes Dec 8, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 2 small comments

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) December 8, 2025 15:52
@jacobrkerstetter jacobrkerstetter merged commit 49acf87 into main Dec 8, 2025
49 of 50 checks passed
@jacobrkerstetter jacobrkerstetter deleted the chore/v1_implementation_of_file_stub branch December 8, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@b-matteo b-matteo Awaiting requested review from b-matteo

Assignees

@jacobrkerstetter jacobrkerstetter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jacobrkerstetter @RobPasMue @b-matteo @pyansys-ci-bot