chore: v1 implementation of beam stub #2444
Open
+206
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
- Coverage 91.56% 91.02% -0.54%
==========================================
Files 169 169
Lines 11859 11884 +25
==========================================
- Hits 10859 10818 -41
- Misses 1000 1066 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobrkerstetter
requested changes
Dec 5, 2025
| ) | ||
|
|
||
| self.stub = BeamsStub(channel) | ||
| self.beam_commands_stub = BeamProfileDataStub |
Contributor
There was a problem hiding this comment.
Suggested change
| self.beam_commands_stub = BeamProfileDataStub | |
| self.stub = BeamProfileDataStub(channel) |
Comment on lines
70
to
78
| # Create the gRPC Line objects | ||
| lines = [] | ||
| for segment in kwargs["segments"]: | ||
| lines.append( | ||
| Line( | ||
| start=from_point3d_to_grpc_point(segment[0]), | ||
| end=from_point3d_to_grpc_point(segment[1]), | ||
| ) | ||
| ) |
Contributor
There was a problem hiding this comment.
Not your fault - this is wrong in v0 too :(. Can you change both to use the from_line_to_grpc_line conversion?
Co-authored-by: Jacob Kerstetter <[email protected]>
Co-authored-by: Jacob Kerstetter <[email protected]>
github-actions
bot
added
maintenance
…m/ansys/pyansys-geometry into ci/v1_implementation_of_beam_stub
github-actions
bot
added
maintenance
RobPasMue
requested changes
Dec 7, 2025
Comment on lines
+71
to
+75
| from_line_to_grpc_line( | ||
| Line( | ||
| start=from_point3d_to_grpc_point(segment[0]), | ||
| end=from_point3d_to_grpc_point(segment[1]), | ||
| ) |
Member
There was a problem hiding this comment.
I think this has to be reverted.. the Line object here referes to the gRPC object already. Please revert
Comment on lines
+105
to
+109
| from_line_to_grpc_line( | ||
| Line( | ||
| start=from_point3d_to_grpc_point(segment[0]), | ||
| end=from_point3d_to_grpc_point(segment[1]), | ||
| ) |
Comment on lines
+79
to
+85
| from_line_to_grpc_line( | ||
| Line( | ||
| start=from_point3d_to_grpc_point(segment[0]), | ||
| end=from_point3d_to_grpc_point(segment[1]), | ||
| ) | ||
| ) | ||
| ) |
Member
There was a problem hiding this comment.
Same comment... I'm not sure how this is even working. You shouldn't be needing to pass through the from_line_to_grpc_line method.
Comment on lines
+123
to
+129
| from_line_to_grpc_line( | ||
| Line( | ||
| start=from_point3d_to_grpc_point(segment[0]), | ||
| end=from_point3d_to_grpc_point(segment[1]), | ||
| ) | ||
| ) | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
V1 implementation of beam stub.
Does not address the following issues
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)