Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDS version 2 compilation error with visual c++ compiler. #95

Open
amod0017 opened this issue Mar 6, 2018 · 3 comments
Open

SDS version 2 compilation error with visual c++ compiler. #95

amod0017 opened this issue Mar 6, 2018 · 3 comments

Comments

@amod0017
Copy link

amod0017 commented Mar 6, 2018

I see there is a fix for version 1 for c++ compiler. Is there anything similar for version 2?
Facing compilation issues, like below:
image
Am I missing something?

@LynnKirby
Copy link

Old issue but if you're still wondering the problem is MSVC doesn't support that attribute syntax. You can look at the changes I made in my fork (https://github.com/LynnKirby/sds), in particular starting here.

@mcclure
Copy link

mcclure commented Nov 7, 2018

I encountered this problem. @LynnKirby what license does your fork use? Would you consider pull requesting your fixes back to this repo?

I feel this issue should be taken seriously...

@LynnKirby
Copy link

@mcclure It's the same license as the original (BSD 2-clause). I haven't bothered to pull request the changes since all the other pull requests are dead in the water.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants