SFTP provider 4.0: create_directory may not apply the expected permissions.

[MatthieuBlais]

Hi team,

We have upgraded the SFTP provider to version 4.0.0 recently, but we notice we are not able to upload files into a newly created directory using GCSToSFTPOperator

We can see the directories are created with these permissions: dr----x--t, which we are not expecting as the default mode is 777.

After investigation, I can see there are 2 methods in the SFTP hook to create a directory: create_directory and mkdir. They use different format for passing the mode to paramiko:

# mkdir
conn.mkdir(path, mode=int(str(mode), 8))
# create_directory
conn.mkdir(path, mode=mode)

The first one seems to convert to octal, while the other one doesn't. Based on paramiko doc, I believe the function expects an octal number.

If I convert 777 to octal, I get 1411, which matches with the dr----x--t permissions we can see.

I would think it's a bug that can be simply fixed by converting mode to octal in create_directory main...MatthieuBlais:airflow:patch-1

WDYT?

[potiuk]

Feel free to fix it

[MatthieuBlais]

Ok will do