Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-38 Programmatic form component #42372

Open
1 task done
pierrejeambrun opened this issue Sep 20, 2024 · 4 comments
Open
1 task done

AIP-38 Programmatic form component #42372

pierrejeambrun opened this issue Sep 20, 2024 · 4 comments
Assignees
Labels
AIP-38 Modern Web Application AIP-50 Trigger DAG UI user Form area:UI Related to UI/UX. For Frontend Developers. kind:meta High-level information important to the community

Comments

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Sep 20, 2024

Brent says:

Let's develop a robust form component that can render many different fields based on the spec it receives. Then we > can use this for advanced dagrun trigger and connection management.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@pierrejeambrun pierrejeambrun added kind:meta High-level information important to the community AIP-38 Modern Web Application labels Sep 20, 2024
@dosubot dosubot bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 20, 2024
@jscheffl jscheffl self-assigned this Oct 3, 2024
@jscheffl
Copy link
Contributor

jscheffl commented Oct 3, 2024

I would try to raise my hand for this. Just need a bit time to get started in the new ecosystem :-D

THe components woul dbe needed for (1) trigger form as well as (2) connection for in the feature set of the legacy UI.

@jscheffl jscheffl added the AIP-50 Trigger DAG UI user Form label Oct 3, 2024
@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Oct 3, 2024

Yes the idea is to have a generic form component, flexible, reusable enough to do any type of form. A good idea would be to take a look into react form libraries out there and find one that looks good. (input validation, error handling, etcc...). In the past I have used formik, I don't know if it is still relevant today or if other libraries are better suited such as https://tanstack.com/form/latest

@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 3, 2024

Updating my comment based on some quick research.

formik: https://formik.org/ Has had long periods of not being maintained, not typescript-first
tanstack/form: https://tanstack.com/form/latest His other libraries, query and table, have been very useful for us, but its still at v0.33.0 so it could change a lot after a v1.0
react-hook-form: https://react-hook-form.com/ Another popular framework.

I would lean towards react-hook-form, idk if we want to rely on an outdated library or anything at a 0.X version

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Oct 3, 2024

I share the feeling for 0.X versions. This is something I mentioned when we considered switching the backend web framework, but still we went with FastAPI, so I would say for consistancy that 0.X version are not a problem for us. (I guess)

And in general tanstack lib are well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-38 Modern Web Application AIP-50 Trigger DAG UI user Form area:UI Related to UI/UX. For Frontend Developers. kind:meta High-level information important to the community
Projects
Development

No branches or pull requests

3 participants