Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: As a user, I want nacos discovery support health check for nacos hosts, so that we can pick a healthy host for operation #8782

Open
ronething opened this issue Feb 3, 2023 · 3 comments
Open

feat: As a user, I want nacos discovery support health check for nacos hosts, so that we can pick a healthy host for operation #8782

ronething opened this issue Feb 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ronething
Copy link
Contributor

Description

refer: #8753 (comment)
@ronething ronething changed the title feat: As a user, I want nacos discovery support health check for nacos hosts, so that we can pick healthy host for operation feat: As a user, I want nacos discovery support health check for nacos hosts, so that we can pick a healthy host for operation Feb 3, 2023
@spacewander
Copy link
Member

Do you mean health check on DP side?

@ronething
Copy link
Contributor Author

Do you mean health check on DP side?

Yes, I found todo in init.lua

apisix/apisix/discovery/nacos/init.lua

Line 150 in 403e4c5

-- TODO Add health check to get healthy nodes.

but if the field hosts is domain name instead of ip, it seems health check is unnecessary.

@spacewander
Copy link
Member

I see

@spacewander spacewander added the enhancement New feature or request label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spacewander @ronething