[ARIES-2159] fix NPE when DatabaseMetaData wants to get connection from DummyDataSource.

Author: jherkel

jpa-container/src/main/java/org/apache/aries/jpa/container/weaving/impl/DummyDataSource.java

@@ -67,6 +67,9 @@ private Object proxyClasses(ClassLoader classLoader, Class<?> type) {
             if (type == Statement.class) {
                 return createProxy(classLoader, PreparedStatement.class);
             }
+            if (type == Connection.class) {
+                return createProxy(classLoader, Connection.class);
+            }
             return null;
         }
 

jpa-container/src/test/java/org/apache/aries/jpa/container/weaving/impl/DummyDataSourceTest.java

@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIESOR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.aries.jpa.container.weaving.impl;
+
+import java.sql.Connection;
+import java.sql.DatabaseMetaData;
+import static org.junit.Assert.assertTrue;
+import org.junit.Test;
+
+public class DummyDataSourceTest {
+
+  @Test
+  public void testGetConnection_String_String() throws Exception {
+    DummyDataSource ds = new DummyDataSource();
+    Connection connection = ds.getConnection("test", "test");
+    DatabaseMetaData databaseMetaData = connection.getMetaData();
+    Connection connectionFromMetaData = databaseMetaData.getConnection();
+    assertTrue(connectionFromMetaData != null);
+  }
+
+  @Test
+  public void testGetConnection_0args() throws Exception {
+    DummyDataSource ds = new DummyDataSource();
+    Connection connection = ds.getConnection();
+    DatabaseMetaData databaseMetaData = connection.getMetaData();
+    Connection connectionFromMetaData = databaseMetaData.getConnection();
+    assertTrue(connectionFromMetaData != null);
+  }
+
+}