Skip to content

Conversation

@jherkel
Copy link

@jherkel jherkel commented Oct 30, 2024

@glimmerveen
Copy link

Hi @jbonofre , would you be able to look into this PR?

@jbonofre
Copy link
Member

@glimmerveen it's on my todo not yet started.

@glimmerveen
Copy link

Hi @jbonofre , any update on this?

@alien11689
Copy link
Contributor

Hi @jherkel @glimmerveen
could you provide a test covering newly added code?
It could be a quite simple test just calling getConnection().getCatalog() ensuring that the NPE is not thrown.

@jherkel
Copy link
Author

jherkel commented Jun 18, 2025

@alien11689 I have added a simple unit test.

Copy link
Contributor

@alien11689 alien11689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jbonofre would you like to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants