use fmtlib instead

Author: lidavidm

c/driver/framework/base_driver.h

@@ -30,6 +30,8 @@
 
 #include <arrow-adbc/adbc.h>
 
+#include "fmt/core.h"
+
 #include "driver/framework/status.h"
 
 /// \file base.h ADBC Driver Framework
@@ -170,19 +172,16 @@ class Option {
             using T = std::decay_t<decltype(value)>;
             if constexpr (std::is_same_v<T, std::string> || std::is_same_v<T, int64_t> ||
                           std::is_same_v<T, double>) {
-              char formatted[24];  // Enough room for double/int64_t
               std::string_view string_value;
-              if constexpr (std::is_same_v<T, std::string>) {
-                string_value = value;
+              std::string allocated_value;
+              if constexpr (std::is_same_v<T, int64_t>) {
+                allocated_value = fmt::format("{}", value);
+                string_value = allocated_value;
+              } else if constexpr (std::is_same_v<T, double>) {
+                allocated_value = fmt::format("{}", value);
+                string_value = allocated_value;
               } else {
-                auto result =
-                    std::to_chars(formatted, formatted + sizeof(formatted), value);
-                if (result.ec != std::errc()) {
-                  return status::Internal("Could not format numeric option value")
-                      .ToAdbc(error);
-                }
-                string_value = std::string_view(
-                    formatted, static_cast<size_t>(result.ptr - formatted));
+                string_value = value;
               }
               size_t value_size_with_terminator = string_value.size() + 1;
               if (*length >= value_size_with_terminator) {

c/driver/framework/status.h

@@ -26,10 +26,8 @@
 #include <variant>
 #include <vector>
 
-#if defined(ADBC_FRAMEWORK_USE_FMT)
 #include <fmt/core.h>
 #include <fmt/format.h>
-#endif
 
 #include <arrow-adbc/adbc.h>
 
@@ -326,7 +324,6 @@ STATUS_CTOR(Unknown, UNKNOWN)
 
 }  // namespace adbc::driver::status
 
-#if defined(ADBC_FRAMEWORK_USE_FMT)
 namespace adbc::driver::status::fmt {
 
 #define STATUS_CTOR(NAME, CODE)                                                     \
@@ -348,7 +345,6 @@ STATUS_CTOR(Unknown, UNKNOWN)
 #undef STATUS_CTOR
 
 }  // namespace adbc::driver::status::fmt
-#endif
 
 #define UNWRAP_ERRNO_IMPL(NAME, CODE, RHS)                                               \
   do {                                                                                   \

c/driver/postgresql/result_helper.cc

@@ -27,7 +27,6 @@
 #include <string>
 #include <vector>
 
-#define ADBC_FRAMEWORK_USE_FMT
 #include "driver/framework/status.h"
 #include "error.h"
 

c/driver/sqlite/sqlite.cc

@@ -26,7 +26,6 @@
 #include <sqlite3.h>
 #include <nanoarrow/nanoarrow.hpp>
 
-#define ADBC_FRAMEWORK_USE_FMT
 #include "driver/framework/base_driver.h"
 #include "driver/framework/connection.h"
 #include "driver/framework/database.h"