feat(python/adbc_driver_manager): handle KeyboardInterrupt #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODOS
|
|
CC @zeroshade @mariusvniekerk how awful is this? 😅 |
lidavidm
commented
Feb 2, 2024
python/adbc_driver_manager/adbc_driver_manager/_blocking_impl.cc
Outdated
Show resolved
Hide resolved
python/adbc_driver_manager/adbc_driver_manager/_blocking_impl.cc
Outdated
Show resolved
Hide resolved
| if threading.current_thread() is not threading.main_thread(): | ||
| return func(*args, **kwargs) | ||
|
|
||
| _init_blocking_call() |
There was a problem hiding this comment.
Does the rest of the body want to be in a mutex? Or are we going to trust the current_thread check?
lidavidm
force-pushed
the
gh1484-bg
branch
13 times, most recently
from
7856659
to
cead49d
Compare
|
I still need to fix this on Windows but I'll have to set up a development environment again |
lidavidm
force-pushed
the
gh1484-bg
branch
2 times, most recently
from
05b5fed
to
9245195
Compare
|
Hmm, I'm unable to reproduce the error in the Conda builds. |
|
If this doesn't work then I'm simply going to disable the feature altogether on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1486.
Fixes #1484.