Skip to content

GH-48210: [C++][Parquet] Fix Bloom Filter logic to enable Parquet DB support on s390x #48211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vishwanatha-HD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-48210: [C++][Parquet] Fix Bloom Filter logic to enable Parquet DB support on s390x #48211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions cpp/src/parquet/bloom_filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

#include "generated/parquet_types.h"

#include "arrow/util/endian.h"
#include "parquet/bloom_filter.h"
#include "parquet/exception.h"
#include "parquet/thrift_internal.h"
Expand Down Expand Up @@ -203,13 +204,14 @@ bool BlockSplitBloomFilter::FindHash(uint64_t hash) const {
const uint32_t bucket_index =
static_cast<uint32_t>(((hash >> 32) * (num_bytes_ / kBytesPerFilterBlock)) >> 32);
const uint32_t key = static_cast<uint32_t>(hash);
const uint32_t* bitset32 = reinterpret_cast<const uint32_t*>(data_->data());
const uint32_t* raw_bitset32 = reinterpret_cast<const uint32_t*>(data_->data());

for (int i = 0; i < kBitsSetPerBlock; ++i) {
const uint32_t bitset_word = ::arrow::bit_util::FromLittleEndian(
raw_bitset32[kBitsSetPerBlock * bucket_index + i]);
// Calculate mask for key in the given bitset.
const uint32_t mask = UINT32_C(0x1) << ((key * SALT[i]) >> 27);
if (ARROW_PREDICT_FALSE(0 ==
(bitset32[kBitsSetPerBlock * bucket_index + i] & mask))) {
if (ARROW_PREDICT_FALSE(0 == (bitset_word & mask))) {
return false;
}
}
Expand All @@ -220,12 +222,16 @@ void BlockSplitBloomFilter::InsertHashImpl(uint64_t hash) {
const uint32_t bucket_index =
static_cast<uint32_t>(((hash >> 32) * (num_bytes_ / kBytesPerFilterBlock)) >> 32);
const uint32_t key = static_cast<uint32_t>(hash);
uint32_t* bitset32 = reinterpret_cast<uint32_t*>(data_->mutable_data());
uint32_t* raw_bitset32 = reinterpret_cast<uint32_t*>(data_->mutable_data());

for (int i = 0; i < kBitsSetPerBlock; i++) {
const int word_index = bucket_index * kBitsSetPerBlock + i;
uint32_t bitset_word = ::arrow::bit_util::FromLittleEndian(raw_bitset32[word_index]);

// Calculate mask for key in the given bitset.
const uint32_t mask = UINT32_C(0x1) << ((key * SALT[i]) >> 27);
bitset32[bucket_index * kBitsSetPerBlock + i] |= mask;
bitset_word |= mask;
raw_bitset32[word_index] = ::arrow::bit_util::ToLittleEndian(bitset_word);
}
}

Expand Down
Loading