Skip to content

Conversation

@ehab20011
Copy link

Please add a meaningful description for your change here

Summary

Fixes #36857: Pass project-id to BigQuery Client in Beam Python SDK

Previously, BigQueryWrapper created the google.cloud.bigquery.Client without explicitly passing the project parameter, causing it to fall back to environment-based project inference. This led to failures in cross-project scenarios, impersonation use cases, and environments where the project ID wasn't available via environment variables or metadata server.

Changes

  • Modified BigQueryWrapper.__init__ in bigquery_tools.py to explicitly extract the project ID from PipelineOptions via GoogleCloudOptions and pass it to gcp_bigquery.Client() constructor
  • Added unit tests to verify:
    • The BigQuery client is constructed with an explicit project kwarg
    • Backward compatibility is maintained when a test client is injected

Testing

  • All existing TestBigQueryWrapper tests pass (29 tests)
  • New tests verify the fix and backward compatibility

Impact

This change ensures that BigQuery operations always use the project ID specified in pipeline options, making the SDK more reliable in:

  • Cross-project Dataflow pipelines
  • Service account impersonation scenarios
  • Airflow/Cloud Run environments
  • Local development without environment variables

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.

  • Update CHANGES.md with noteworthy changes.

  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)


Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ehab20011, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the BigQuery client in the Beam Python SDK did not explicitly specify a project ID, leading to failures in complex deployment scenarios. By ensuring the project ID is always derived from pipeline options, the change significantly improves the robustness and predictability of BigQuery interactions across different environments and use cases.

Highlights

  • Explicit Project ID for BigQuery Client: The BigQueryWrapper now explicitly extracts the project ID from PipelineOptions and passes it to the google.cloud.bigquery.Client constructor, preventing reliance on environment-based inference.
  • Improved Reliability: This change enhances the reliability of BigQuery operations in cross-project scenarios, service account impersonation, and various deployment environments (Airflow, Cloud Run, local development).
  • New Unit Tests: Added unit tests to verify that the BigQuery client is constructed with an explicit project keyword argument and that backward compatibility is maintained when a test client is injected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Pass project-id to BigQuery Client in Beam Python SDK

1 participant