Fix BigQuery Client not having an explicit ProjectID #36945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Summary
Fixes #36857: Pass project-id to BigQuery Client in Beam Python SDK
Previously,
BigQueryWrappercreated thegoogle.cloud.bigquery.Clientwithout explicitly passing theprojectparameter, causing it to fall back to environment-based project inference. This led to failures in cross-project scenarios, impersonation use cases, and environments where the project ID wasn't available via environment variables or metadata server.Changes
BigQueryWrapper.__init__inbigquery_tools.pyto explicitly extract the project ID fromPipelineOptionsviaGoogleCloudOptionsand pass it togcp_bigquery.Client()constructorprojectkwargTesting
TestBigQueryWrappertests pass (29 tests)Impact
This change ensures that BigQuery operations always use the project ID specified in pipeline options, making the SDK more reliable in:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.Update
CHANGES.mdwith noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.