Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf v5 support #2757

Closed
Tradias opened this issue Sep 4, 2024 · 2 comments · Fixed by #2782
Closed

Protobuf v5 support #2757

Tradias opened this issue Sep 4, 2024 · 2 comments · Fixed by #2782
Assignees

Comments

@Tradias
Copy link

Tradias commented Sep 4, 2024

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

The brpc vcpkg port depends on protobuf. Since vcpkg maintains a single-version scheme, updating protobuf requires brpc to support it.

Describe the solution you'd like (描述你期望的解决方法)

Protobuf v5 support. V4 support can be broken in the process.

Describe alternatives you've considered (描述你想到的折衷方案)

Patching brpc, see https://github.com/microsoft/vcpkg/blob/052b06a95da4cee184bab4422e02e7f316055a99/ports/brpc/protobuf.patch

Additional context/screenshots (更多上下文/截图)

@chenBright
Copy link
Contributor

cc @wasphin

@wasphin wasphin self-assigned this Oct 8, 2024
@wasphin
Copy link
Member

wasphin commented Oct 8, 2024

Just missed this, will try it this weekend, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants