-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: karavan.git.repository doesn't work correct at 4.7.0 #1347
Comments
Could you please try with |
Yeah, now it sees correct repository and according to the logs writes on the correct branch, but I can't see anything. The repository is empty. If I change image version to 4.6.0 it works fine
|
We have a similar problem. First we replaced the karavan.git.repository with KARAVAN_GIT_REPOSITORY in the deployment.yaml to get the git connection to working. The problem now is with the git branch. Karavan always uses main branch and pushes to the branch are not working. We replaced |
Please share your deployment.yaml |
Here is the contents of the deployment.yaml
|
I think this would be fixed with #1389 |
I tried the new deployment.yaml from the PR and the Karavan still uses the main branch regardless of the value in KARAVAN_GIT_BRANCH secret. |
Yeah, sorry I missed the main reason of this bug report. The PR I said above only chances the env var to upper case, but I did not change anything related to java code (that does the poll/push from git). Note: my push was not working too, but after some debugging it was because my git repo's default branch was "master" and karavan-app tried to check out the inexistent branch and gives an error. Just until this is fixed, change the default branch of your repo to "main" and the pushes may work |
Thanks, our default is main. Problem is that our specific branches get ignored. When I compared the versions 4.6.0 and 4.7.0 of |
Describe the bug
I tried to upgrade karavan from 4.5.1 to 4.7.0 in my k8s cluster and got an error. For some reason it uses gitea instead of my gitlab url. In pod logs:
The environment variable
karavan.git.repository
set up correctly:Downgrade to 4.6.0 or 4.5.1 fixed this problem
Steps to reproduce the behavior
Use custom
karavan.git.repository
and create kubernetes deployment with karavan version 4.7.0Variant
Web Application
Container Management (if applicable)
Kubernetes
Operating System (if applicable)
None
Version
4.7.0
Relevant log output
The text was updated successfully, but these errors were encountered: