Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secstorage.nfs.version is not used in two scenarios #9469

Closed
weizhouapache opened this issue Jul 30, 2024 · 9 comments · Fixed by #9559
Closed

secstorage.nfs.version is not used in two scenarios #9469

weizhouapache opened this issue Jul 30, 2024 · 9 comments · Fixed by #9559

Comments

@weizhouapache
Copy link
Member

the NFS version is not considered in two scenarios

  • During systemvm template registration

private static final String MOUNT_COMMAND = "sudo mount -t nfs %s %s";

String mount = String.format(MOUNT_COMMAND, host + ":" + mountPath, path);
Script.runSimpleBashScript(mount);

  • When cleanup diagnosis files

private void cleanupOldDiagnosticFiles(DataStore store) {
String mountPoint = null;
mountPoint = serviceImpl.mountManager.getMountPoint(store.getUri(), null);

the nfs version is set to null

ISSUE TYPE
  • Bug Report
COMPONENT NAME

CLOUDSTACK VERSION

CONFIGURATION
OS / ENVIRONMENT
SUMMARY
STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

@Revellski
Copy link

We can also not mount CD ISO to instances unless the NFS server explicitly supports NFSv3. This is with secstorage.nfs.version being set to 4.0 and 4.1.

Cloudstack 4.19.1.0
SSVM 4.19.1.0
Hypervisor XenServer

@weizhouapache
Copy link
Member Author

We can also not mount CD ISO to instances unless the NFS server explicitly supports NFSv3. This is with secstorage.nfs.version being set to 4.0 and 4.1.

Cloudstack 4.19.1.0
SSVM 4.19.1.0
Hypervisor XenServer

that's good point @Revellski , thanks

we need to review all the operations which mount secondary storage on hosts or management servers, including

  • mount ISO
  • mount configdrive ISO
  • etc

@DaanHoogland
Copy link
Contributor

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

@DaanHoogland
Copy link
Contributor

also editting labels at the same time seems to clash :)

@JoaoJandre
Copy link
Contributor

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

@DaanHoogland Yeah, this makes sense.
Also, I took some time to realize we where editing the issues' labels/milestones at the same time xD.

shwstppr added a commit to shapeblue/cloudstack that referenced this issue Aug 21, 2024
@shwstppr
Copy link
Contributor

@weizhouapache I've created #9559 for the original issues. Regarding #9469 (comment), do we any time mount ISOs on the hypervisor hosts?

@weizhouapache
Copy link
Member Author

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

@DaanHoogland Yeah, this makes sense. Also, I took some time to realize we where editing the issues' labels/milestones at the same time xD.

I think there might be several checks , for example

  • copy from primary to secondary (extract volume ? take volume snapshot ?)
  • copy from secondary to primary (deploy vm from new template ? )
  • mount configdrive ISO

@shwstppr shwstppr linked a pull request Aug 22, 2024 that will close this issue
14 tasks
@abh1sar abh1sar assigned shwstppr and unassigned abh1sar Aug 22, 2024
shwstppr added a commit to shapeblue/cloudstack that referenced this issue Aug 29, 2024
@DaanHoogland
Copy link
Contributor

I think there might be several checks , for example

* copy from primary to secondary (extract volume ? take volume snapshot ?)

* copy from secondary to primary (deploy vm from new template ? )

* mount configdrive ISO

Do we create new tickets for these @weizhouapache ? (and close this one!)

@weizhouapache
Copy link
Member Author

I think there might be several checks , for example

* copy from primary to secondary (extract volume ? take volume snapshot ?)

* copy from secondary to primary (deploy vm from new template ? )

* mount configdrive ISO

Do we create new tickets for these @weizhouapache ? (and close this one!)

I did not check the scenarios, therefore cannot say if there are issues.
closing this ticket as the two issues reported in the description have been addressed by #9559

thanks @shwstppr @DaanHoogland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment