Embedding Android WebView doc looks broken

[brody4hire]

Issue Type
[x] Bug
[ ] Feature Request

Priority
[ ] Minor
[x] Major
[ ] Critical
[ ] Blocker

Environment

• OS: N/A
• Browser: N/A

Description

In https://cordova.apache.org/docs/en/latest/guide/platforms/android/webview.html:

Sample code seems to use a Config object class.

The one place where I see a Config class documented is in: https://developer.android.com/reference/android/util/Config

where I see no init method documented.

As a general rule the document should never assume the user implicitly knows that s/he has to import a class from a package somewhere.

This looks broken to me, hoping to see an explanation and solution someday soon.

P.S. android.util.Config class looks deprecated according to https://developer.android.com/reference/android/util/Config.

[brody4hire]

ref:

• Change from CordovaWebView to SystemWebView in latest Cordova not working cordova-android#494
• https://stackoverflow.com/questions/45505956/trying-to-embed-cordova-app-into-native-android
• Full android.util.Config class name for Android #883 (PR Full android.util.Config class name for Android #883)

[brody4hire]

@martinhorvath commented in apache/cordova-android#494 (comment):

I [...] tried to reflect my findings in this update: apache/cordova-docs@6dc8836

Can somebody check if this is useful for others?

A pull request would be really appreciated.

[martinhorvath]

I had to find out that I really messed up the conventions of the commit and didn't want to create an even bigger mess with a pull request. Should I?

[janpio]

I honestly don't understand how you were able to commit to this repo and where this commit actually "lives". How did you do that @martinhorvath? Which branch did you commit to?

[dpogue]

@janpio The commit is in his fork, it's just a GitHub URL/UI thing that makes it appear like it's in apache/cordova-docs.

[martinhorvath]

It indeed is... I thought "lets see what happens if I suggest an edit using the url from the offical docs". So.... what shall I do? :-)

[brody4hire]

@martinhorvath a pull request would be much easier for us to track and comment on than a loose commit. While we would prefer the proposed commits to be cleaner your proposed commit would be better than nothing.

[janpio]

Got it: martinhorvath@6dc8836

[janpio]

You can just create a Pull Request into this repository from your patch-1 branch. Start here @martinhorvath: https://github.com/apache/cordova-docs/compare

[brody4hire]

And we can always use git show -b 6dc8836 or git diff -b to ignore the space changes.

[martinhorvath]

Ok let's see if I can fix this...

[martinhorvath]

PR done, I tried my best to follow the contribution guidelines. Would appreciate if you let me know what I missed to do.
--> #904