diff --git a/parent/pom.xml b/parent/pom.xml index 627953f4db1..57d44b71b6c 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -435,7 +435,7 @@ net.sourceforge.pmd pmd-java - 7.10.0 + 7.11.0 diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/AbstractStartEndEventProducer.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/AbstractStartEndEventProducer.java index 43938b2d4d6..3a28b0fb3be 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/AbstractStartEndEventProducer.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/AbstractStartEndEventProducer.java @@ -29,6 +29,7 @@ import org.apache.cxf.service.model.ServiceInfo; import org.omg.CORBA.ORB; +@SuppressWarnings("PMD.FinalFieldCouldBeStatic") public abstract class AbstractStartEndEventProducer implements CorbaTypeEventProducer { diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaOctetSequenceEventProducer.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaOctetSequenceEventProducer.java index da3deb43e41..cd6010f2e4d 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaOctetSequenceEventProducer.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaOctetSequenceEventProducer.java @@ -25,6 +25,7 @@ import javax.xml.stream.events.Attribute; import javax.xml.stream.events.Namespace; +@SuppressWarnings("PMD.FinalFieldCouldBeStatic") public class CorbaOctetSequenceEventProducer implements CorbaTypeEventProducer { int state; diff --git a/systests/transports/src/test/java/org/apache/cxf/systest/http/HTTPConduitIoExceptionsTest.java b/systests/transports/src/test/java/org/apache/cxf/systest/http/HTTPConduitIoExceptionsTest.java index 6cc0f3681b8..9a7b7993b9e 100644 --- a/systests/transports/src/test/java/org/apache/cxf/systest/http/HTTPConduitIoExceptionsTest.java +++ b/systests/transports/src/test/java/org/apache/cxf/systest/http/HTTPConduitIoExceptionsTest.java @@ -82,7 +82,7 @@ public void testServiceUnavailable() throws Exception { exception.expect(WebServiceException.class); exception.expectCause(new TypeSafeMatcher() { - private final String message = "HTTP response '503: Service Unavailable' when " + private static final String message = "HTTP response '503: Service Unavailable' when " + "communicating with http://localhost:" + BadServer.PORT + "/Mortimer"; @Override @@ -109,7 +109,7 @@ public void testNotFound() throws Exception { exception.expect(WebServiceException.class); exception.expectCause(new TypeSafeMatcher() { - private final String message = "HTTP response '404: Not Found' when " + private static final String message = "HTTP response '404: Not Found' when " + "communicating with http://localhost:" + BadServer.PORT + "/Mortimer"; @Override diff --git a/systests/transports/src/test/java/org/apache/cxf/systest/servlet/NoSpringServletClientTest.java b/systests/transports/src/test/java/org/apache/cxf/systest/servlet/NoSpringServletClientTest.java index f7933587344..175450fce0f 100644 --- a/systests/transports/src/test/java/org/apache/cxf/systest/servlet/NoSpringServletClientTest.java +++ b/systests/transports/src/test/java/org/apache/cxf/systest/servlet/NoSpringServletClientTest.java @@ -51,10 +51,10 @@ public class NoSpringServletClientTest extends AbstractServletTest { private static final String PORT = NoSpringServletServer.PORT; + private static final String SERVICE_URL = "http://localhost:" + PORT + "/soap/"; private static Bus serverBus; private static NoSpringServletServer server; private final QName portName = new QName("http://apache.org/hello_world_soap_http", "SoapPort"); - private final String serviceURL = "http://localhost:" + PORT + "/soap/"; @BeforeClass public static void startServers() throws Exception { @@ -73,7 +73,7 @@ public static void shutdownServer() throws Exception { @Test public void testBasicConnection() throws Exception { - SOAPService service = new SOAPService(new URL(serviceURL + "Greeter?wsdl")); + SOAPService service = new SOAPService(new URL(SERVICE_URL + "Greeter?wsdl")); Greeter greeter = service.getPort(portName, Greeter.class); try { String reply = greeter.greetMe("test"); @@ -90,7 +90,7 @@ public void testBasicConnection() throws Exception { @Test public void testHelloService() throws Exception { JaxWsProxyFactoryBean cpfb = new JaxWsProxyFactoryBean(); - String address = serviceURL + "Hello"; + String address = SERVICE_URL + "Hello"; cpfb.setServiceClass(Hello.class); cpfb.setAddress(address); Hello hello = (Hello) cpfb.create(); @@ -133,7 +133,7 @@ private void startServer() { @Test public void testGetServiceList() throws Exception { try (CloseableHttpClient client = HttpClients.createDefault()) { - final HttpGet method = new HttpGet(serviceURL + "/services"); + final HttpGet method = new HttpGet(SERVICE_URL + "/services"); try (CloseableHttpResponse res = client.execute(method)) { HTMLDocumentImpl doc = parse(res.getEntity().getContent()); @@ -144,9 +144,9 @@ public void testGetServiceList() throws Exception { s.add(l.getHref()); } assertEquals("There should be 3 links for the service", 3, links.size()); - assertTrue(s.contains(serviceURL + "Greeter?wsdl")); - assertTrue(s.contains(serviceURL + "Hello?wsdl")); - assertTrue(s.contains(serviceURL + "?wsdl")); + assertTrue(s.contains(SERVICE_URL + "Greeter?wsdl")); + assertTrue(s.contains(SERVICE_URL + "Hello?wsdl")); + assertTrue(s.contains(SERVICE_URL + "?wsdl")); assertEquals("text/html", getContentType(res)); } }