Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ANSI support for Add #536

Open
andygrove opened this issue Jun 6, 2024 · 3 comments · May be fixed by #616
Open

Add ANSI support for Add #536

andygrove opened this issue Jun 6, 2024 · 3 comments · May be fixed by #616
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

Spark has specific handling of overflows when ANSI mode is enabled and we need to add the same in Comet.

Describe the potential solution

No response

Additional context

No response

@andygrove andygrove added the enhancement New feature or request label Jun 6, 2024
@andygrove andygrove added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 6, 2024
@planga82
Copy link
Contributor

planga82 commented Jun 7, 2024

I want to try this one!

@dharanad
Copy link

dharanad commented Jun 24, 2024

Hello @planga82

Just wanted to check in and see if you're still working on this task. I'm actually working on the subtraction variant of the same task, and I thought it might be helpful to chat about our approaches. There's a good chance one of our solutions could build upon the other!

Let me know if you're available to discuss sometime.

Here is the Draft PR: #593

@planga82
Copy link
Contributor

Hello @dharanad
Yes, I'm working on it, but I don't have much time, so I'm going slow. The structure of the solution I'm working on is quite similar to yours, basically a wrapper.
In Spark, the implementation uses the Java Math.addExact function. Basically, I'm trying to reproduce that implementation using Datafusion functions.
Thanks for sharing your PR, I will keep an eye on your progress to adapt my solution to be compatible with your code, and I will create a PR when I achive a working solution.

@planga82 planga82 linked a pull request Jul 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants