Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for COMET_PARQUET_PARALLEL_IO_ENABLED #876

Open
andygrove opened this issue Aug 27, 2024 · 1 comment
Open

Add documentation for COMET_PARQUET_PARALLEL_IO_ENABLED #876

andygrove opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

We have some undocumented configs COMET_PARQUET_PARALLEL_IO_ENABLED and COMET_PARQUET_PARALLEL_IO_THREADS in ReadOptions.

They seem to be specific to the Comet native Parquet reader.

It would be nice to have some documenation. Can these be added to CometConf?

public class ReadOptions {
  private static final Logger LOG = LoggerFactory.getLogger(ReadOptions.class);
  public static final String COMET_PARQUET_PARALLEL_IO_ENABLED =
      "comet.parquet.read.parallel.io.enabled";
  public static final boolean COMET_PARQUET_PARALLEL_IO_ENABLED_DEFAULT = true;

  public static final String COMET_PARQUET_PARALLEL_IO_THREADS =
      "comet.parquet.read.parallel.io.thread-pool.size";
  public static final int COMET_PARQUET_PARALLEL_IO_THREADS_DEFAULT = 32;

Describe the potential solution

No response

Additional context

No response

@andygrove andygrove added the enhancement New feature or request label Aug 27, 2024
@parthchandra
Copy link
Contributor

@andygrove Please assign this to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants