Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quotient filter builder bucket suggestion change #580

Closed
c-dickens opened this issue Jul 3, 2024 · 1 comment
Closed

quotient filter builder bucket suggestion change #580

c-dickens opened this issue Jul 3, 2024 · 1 comment

Comments

@c-dickens
Copy link

The Quotient filter number of slots suggestion function currently hardcodes the load factor for the lgNumSlots suggestion. When we decide whether to pass the LOAD_FACTOR constant as a parameter to the filter, we also need to appropriately update the suggestion functions.

Alternatively, we could add a further parameter to suggestLgNumSlots(long maxDistinctItems) to change it to suggestLgNumSlots(long maxDistinctItems, double maxLoad) along with the change
byte result = (byte) Math.ceil(Math.log(maxDistinctItems / maxLoad) / Math.log(2));

@c-dickens
Copy link
Author

Resolved in #584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant