We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I am not clear why we set the hikari thread pool size, I don't find out any benchmark test result.
Following https://github.com/brettwooldridge/HikariCP/wiki/About-Pool-Sizing, I hope to remove some configurations of hikari, the default setting is great enough. We shouldn't change the default setting unless we have benchmark evidence.
dolphinscheduler/dolphinscheduler-api/src/main/resources/application.yaml
Lines 52 to 62 in e66441a
Only keep the pool name and connection-test-query hikari: connection-test-query: select 1 pool-name: DolphinScheduler
pool name
connection-test-query
Compatible with all version.
Test by e2e.
The text was updated successfully, but these errors were encountered:
ruanwenjun
Successfully merging a pull request may close this issue.
Search before asking
Motivation
I am not clear why we set the hikari thread pool size, I don't find out any benchmark test result.
Following https://github.com/brettwooldridge/HikariCP/wiki/About-Pool-Sizing, I hope to remove some configurations of hikari, the default setting is great enough. We shouldn't change the default setting unless we have benchmark evidence.
dolphinscheduler/dolphinscheduler-api/src/main/resources/application.yaml
Lines 52 to 62 in e66441a
Design Detail
Only keep the
pool name
andconnection-test-query
hikari:
connection-test-query: select 1
pool-name: DolphinScheduler
Compatibility, Deprecation, and Migration Plan
Compatible with all version.
Test Plan
Test by e2e.
Code of Conduct
The text was updated successfully, but these errors were encountered: