[DSIP-39][parameter] Startup parameters/global parameters/project parameters support set data type

[sdhzwc]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Motivation

Currently startup parameters, global parameters, project parameters do not support custom data value types, the default is VARCHAR data value type, if I want to use the data type is LONG, this time there is no way to carry out the operation, so this optimization point is to give more choice points to the user, to increase the user experience.

Design Detail

一、 DESC：
This PR is for the startup parameter, global parameter, project parameter support custom data value type, to meet our needs for data use, increase user experience. Which I did not modify the logic of the big, just load the data value type to personalize the limited operation, specifically the following points:

• 1.1 the default data type of startup parameters, global parameters, project parameters is VARCHAR, then this time I transformed this, support for custom data types and compatible with the original data type operation.
• 1.2 StartParams was originally MAP way, now changed to LIST, which I judged whether it is JSON compatible operation.
• 1.3 add New UI
• 1.4 add UT

二、 EFFECT DISPLAY：
2.1 GIF

2.2 Startup Parameters

2.3 Global Parameters

2.4 Project Parameters

Compatibility, Deprecation, and Migration Plan

Compatibility with latest version.

Test Plan

Test by UT.

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[ruanwenjun]

Good idea, do you have any designs?

[sdhzwc]

Good idea, do you have any designs?

1, the first step in the database to increase param_data_type field default value is VARCHAR
2, the second step to modify the add, modify, query logic
3, the third step is to modify the corresponding loading logic
4, and finally increase the UI and UT

[ruanwenjun]

Good idea, do you have any designs?

1, the first step in the database to increase param_data_type field default value is VARCHAR 2, the second step to modify the add, modify, query logic 3, the third step is to modify the corresponding loading logic 4, and finally increase the UI and UT

The design is too simple, since this is a new feature, please change the issue to DSIP and provide the detail design, then we can discuss the design.

Startup parameters/global parameters/task parameters also need to have types, otherwise, this will be very strange and think of as a bug.

[sdhzwc]

Good idea, do you have any designs?

1, the first step in the database to increase param_data_type field default value is VARCHAR 2, the second step to modify the add, modify, query logic 3, the third step is to modify the corresponding loading logic 4, and finally increase the UI and UT

The design is too simple, since this is a new feature, please change the issue to DSIP and provide the detail design, then we can discuss the design.

Startup parameters/global parameters/task parameters also need to have types, otherwise, this will be very strange and think of as a bug.

In fact, this is not a new feature, the parameter priority and loading order is not changed, just optimize the type of parameter values, from the default VARCHAR to now custom type

[ruanwenjun]

Good idea, do you have any designs?

1, the first step in the database to increase param_data_type field default value is VARCHAR 2, the second step to modify the add, modify, query logic 3, the third step is to modify the corresponding loading logic 4, and finally increase the UI and UT

The design is too simple, since this is a new feature, please change the issue to DSIP and provide the detail design, then we can discuss the design.
Startup parameters/global parameters/task parameters also need to have types, otherwise, this will be very strange and think of as a bug.

In fact, this is not a new feature, the parameter priority and loading order is not changed, just optimize the type of parameter values, from the default VARCHAR to now custom type

Right now, we don't support types in DS project params/workflow params/ startup params, this issue is want to support this, so this is a new feature.

You changed the API interface, this is an incompatible change, but it doesn't announce in the issue/PR. The worst thing that can happen is that the user cp's this PR and the original interface will be unusable.

This is why I request a DSIP.

In the description and PR, I didn't see there exists a validation step, this means I can create a parameter with the type int and value tom? This is unacceptable.

[sdhzwc]

Good idea, do you have any designs?

1, the first step in the database to increase param_data_type field default value is VARCHAR 2, the second step to modify the add, modify, query logic 3, the third step is to modify the corresponding loading logic 4, and finally increase the UI and UT

The design is too simple, since this is a new feature, please change the issue to DSIP and provide the detail design, then we can discuss the design.
Startup parameters/global parameters/task parameters also need to have types, otherwise, this will be very strange and think of as a bug.

In fact, this is not a new feature, the parameter priority and loading order is not changed, just optimize the type of parameter values, from the default VARCHAR to now custom type

Right now, we don't support types in DS project params/workflow params/ startup params, this issue is want to support this, so this is a new feature.

You changed the API interface, this is an incompatible change, but it doesn't announce in the issue/PR. The worst thing that can happen is that the user cp's this PR and the original interface will be unusable.

This is why I request a DSIP.

In the description and PR, I didn't see there exists a validation step, this means I can create a parameter with the type int and value tom? This is unacceptable.

I understand what you mean, in fact, the new data value field, does not affect its original logic, because the default value of the field in the database is VARCHAR, in fact, has done a compatible operation!
In fact, I feel that there is a point that really need to be optimized, that is, the global parameters, start parameters, if only the project parameters, custom parameters are indeed a little strange!

[ruanwenjun]

@sdhzwc It's OK for me to support the global params/ start parameters in different PR(it's needed to create sub-issues for this).

I see in the PR, this interface
has break the competition. DSIP means this PR introduces a big change. All changes to the API and table structure are considered as big changes

[sdhzwc]

一、 DESC：
This PR is for the startup parameter, global parameter, project parameter support custom data value type, to meet our needs for data use, increase user experience. Which I did not modify the logic of the big, just load the data value type to personalize the limited operation, specifically the following points:
1, the default data type of startup parameters, global parameters, project parameters is VARCHAR, then this time I transformed this, support for custom data types and compatible with the original data type operation.
2, StartParams was originally MAP way, now changed to LIST, which I judged whether it is JSON compatible operation.
3、add New UI
4, add UT

At present is my optimization of the function of the operation, with the design of the language I may not be able to express the situation, where insufficient can be listed, I will be improved

二、 EFFECT DISPLAY：
2.1 GIF

2.2 Startup Parameters

2.3 Global Parameters

2.4 Project Parameters

@ruanwenjun I've changed it to DSIP and you can see where else it doesn't fit.

[ruanwenjun]

@sdhzwc Great, basically LGTM, I have add this issue to DSIP list, please change the issue description, you can refer #15931, DSIP should contains Motivation, Design Detail, Compatibility, Deprecation, and Migration Plan, Test Plan.