[DSIP-75] Support auto add license header by spotless #16643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
SbloodyS,
EricGao888,
caishunfeng and
Gallardot
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_supportAutoAddLicenseWithSpotless
branch
4 times, most recently
from
8701c7b
to
c14499d
Compare
SbloodyS
reviewed
Sep 21, 2024
Comment on lines
2
to
8
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at |
There was a problem hiding this comment.
Can we keep the same as we are now so that we don't need to change too many files.
There was a problem hiding this comment.
Can we keep the same as we are now so that we don't need to change too many files.
+1
There was a problem hiding this comment.
No, spotless only support one license file.
ruanwenjun
force-pushed
the
dev_wenjun_supportAutoAddLicenseWithSpotless
branch
from
c14499d
to
b216c84
Compare
Gallardot
approved these changes
Sep 22, 2024
ruanwenjun
force-pushed
the
dev_wenjun_supportAutoAddLicenseWithSpotless
branch
from
b216c84
to
d4f8768
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16642
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md