Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Leakage in pre-processing #20

Open
parthkl021 opened this issue Mar 24, 2024 · 0 comments
Open

Data Leakage in pre-processing #20

parthkl021 opened this issue Mar 24, 2024 · 0 comments

Comments

@parthkl021
Copy link

In reference to this snippet from the preprocessing section in the file model_notebook.ipynb

for col in data.columns:
        if(col not in categorical):
            data[col] = (data[col].astype('float') - np.mean(data[col].astype('float')))/np.std(data[col].astype('float'))

The normalization is done on the whole data (i.e. when the train and test split did not occur). This means that information from the test set is used to scale the training set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant